Merge into development-branch : cover-nbs-with-acceptance-tests : Code : Mir

Reviewer	Review Type	Date Requested	Status
Alan Griffiths			Approve on 2016-03-02
Mir CI Bot	continuous-integration		Approve on 2016-03-01
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2016-02-23
Alexandros Frantzis (community)			Approve on 2016-02-22
Cemil Azizoglu (community)		2016-01-14	Approve on 2016-02-11
Review via email: mp+282633@code.qastaging.launchpad.net

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-01-14:

#

FAILED: Continuous integration, rev:3108
https://mir-jenkins.ubuntu.com/job/mir-ci/55/
Executed test runs:
None: https://mir-jenkins.ubuntu.com/job/generic-update-mp/55/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/55/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-14:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6020/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-02:

#

FAILED: Continuous integration, rev:3109
https://mir-jenkins.ubuntu.com/job/mir-ci/207/
Executed test runs:
None: https://mir-jenkins.ubuntu.com/job/generic-update-mp/208/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/207/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-02:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6186/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-02-03:

#

(working on fixing)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-03:

#

FAILED: Continuous integration, rev:3112
https://mir-jenkins.ubuntu.com/job/mir-ci/214/
Executed test runs:
None: https://mir-jenkins.ubuntu.com/job/generic-update-mp/214/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/214/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-03:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6191/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-05:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/245/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-05:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6220/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cemil Azizoglu (cemil-azizoglu) wrote on 2016-02-08:

#

Unneeded space
318 +

------------------------------------------------------------------------------
Indentation
433 - EXPECT_CALL(*mock_channel, on_buffer_stream_create(_,_))
434 + EXPECT_CALL(*mock_channel, on_buffer_stream_create(_,_))

------------------------------------------------------------------------------
Test name should be triple_buffered_client_has_latency_less_than_two_frames?
+TEST_F(ClientLatency, triple_buffered_client_has_less_latency_less_than_two_frames)
344

review: Needs Fixing

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-08:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/257/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-02-09:

#

still fixing, will probably want to trigger CI on this a few times before a TA

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-09:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/261/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-09:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6236/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-09:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6238/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-09:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6241/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-09:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6243/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-09:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6246/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-10:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/279/rebuild

review: Approve (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-10:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/280/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-10:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6263/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-11:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6266/rebuild

review: Approve (continuous-integration)

Revision history for this message

Cemil Azizoglu (cemil-azizoglu) wrote on 2016-02-11:

#

My "needs fixing"s have been addressed.

review: Approve

Revision history for this message

Alexandros Frantzis (afrantzis) wrote on 2016-02-12:

#

struct NullDisplayBufferCompositor : compositor::DisplayBufferCompositor
+ for(auto elem : seq)
+ {
+ elem->rendered();
+ elem->renderable()->buffer();
+ }

The NullDisplayBufferCompositor is meant to not process any elements. The new code changes this behavior and may invalidate tests (e.g., the tests could still pass but they won't be properly testing what they were suppose to test).

+ try
+ {
             map->with_stream_do(mf::BufferStreamId(seq.buffer_request().id().value()),
             [&] (mcl::ClientBufferStream* stream) {
                 if (stream)
                     stream->buffer_available(seq.buffer_request().buffer());
             });
+ }
+ catch (std::exception& e)
+ {
+ for(auto i = 0; i < seq.buffer_request().buffer().fd_size(); i++)
+ close(seq.buffer_request().buffer().fd(i));
+ throw e;
+ }

If !stream, the buffer is not processed and any file descriptors will be leaked.

review: Needs Fixing

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-17:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/324/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6313/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/351/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alexandros Frantzis (afrantzis) wrote on 2016-02-22:

#

+ if (!map)
map->with_stream_do(mf::BufferStreamId(seq.buffer_request().id().value()),

if !map we will segfault.

Looks good otherwise.

review: Needs Fixing

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-02-22:

#

@alf,
Thanks, silly mistake corrected!

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/354/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6341/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alexandros Frantzis (afrantzis) wrote on 2016-02-22:

#

Looks good.

review: Approve

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-02-22:

#

- std::unique_lock<decltype(mutex)> lock(mutex);
return buffer_depository->current_buffer_id();

This looks suspect, but probably only because buffer_depository isn't declared const and should be.

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-02-22:

#

This MP includes the changes to run the tests both NBS and OBS /and/ changes to the tests themselves.

I assume that the latter are required to ensure the tests pass with NBS, but they result in some tests that check different things. In particular, "ClientLatency.triple_buffered_client_uses_all_buffers morphs" to "ClientLatency.triple_buffered_client_has_less_than_two_frames_latency" and gains a "visible_surface.reset()" call at the end of the test.

I *think* the visible_surface.reset() is needed because the changed test fixture no longer does the mir_surface_release_sync() in TearDown(). But surely, it would be better fix this in the fixture, not the test case?

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6345/rebuild

review: Approve (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-23:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/368/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-23:

#

FAILED: Continuous integration, rev:3130
http://jenkins.qa.ubuntu.com/job/mir-ci/6360/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/6013/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4920/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5969/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/684/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/684/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5966/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6360/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-23:

#

FAILED: Continuous integration, rev:3130
http://jenkins.qa.ubuntu.com/job/mir-ci/6361/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/6015/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4922/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5971/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/685/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/685/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5968/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6361/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-23:

#

FAILED: Continuous integration, rev:3130
http://jenkins.qa.ubuntu.com/job/mir-ci/6362/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/6016/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4923/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5972/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/686/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/686/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5969/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6362/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-23:

#

FAILED: Continuous integration, rev:3130
http://jenkins.qa.ubuntu.com/job/mir-ci/6363/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/6018/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4925/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5974/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/687/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/687/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5971/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6363/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-02-25:

#

The changes to "SurfaceScaling.compositor_sees_size_different_when_scaled" fit the name, but...

...it appears to remove a hidden test that should be called "SurfaceScaling.when_not_scaled_compositor_sees_same_size"

Have I misunderstood the test, or has the functionality changed? (And is the change important?)

review: Needs Information

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-26:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/420/rebuild

review: Approve (continuous-integration)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-02-29:

#

Linked a new bug that is fixed by this branch.

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-29:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/433/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-29:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/438/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-29:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/442/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alexandros Frantzis (afrantzis) wrote on 2016-02-29:

#

clang build is failing with:

11: ==14654== Invalid read of size 1
18:11:47 11: ==14654== at 0x4C2F122: strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
18:11:47 11: ==14654== by 0x7399E68: std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.20)
18:11:47 11: ==14654== by 0x404CE3A: boost::exception_detail::diagnostic_information_impl(boost::exception const*, std::exception const*, bool, bool) (diagnostic_information.hpp:157)
18:11:47 11: ==14654== by 0x404CAF5: std::string boost::diagnostic_information<std::exception>(std::exception const&, bool) (in /��BUILDDIR��/mir-0.20.0+16.04.20160219+vivid271bzr3133/obj-x86_64-linux-gnu/lib/libmirclient.so.9)
18:11:47 11: ==14654== by 0x40A04B9: mir_buffer_stream_swap_buffers (mir_buffer_stream_api.cpp:124)
18:11:47 11: ==14654== by 0x40A05CE: mir_buffer_stream_swap_buffers_sync (mir_buffer_stream_api.cpp:130)
18:11:47 11: ==14654== by 0x9356E9: ServerDisconnect_is_detected_by_client_Test::TestBody() (test_server_disconnect.cpp:89)
...
Address 0x121854c8 is 24 bytes inside a block of size 39 free'd
18:11:47 11: ==14654== at 0x4C2D2E0: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
18:11:47 11: ==14654== by 0x73B9862: std::future_error::what() const (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.20)
18:11:47 11: ==14654== by 0x404CC0A: boost::exception_detail::diagnostic_information_impl(boost::exception const*, std::exception const*, bool, bool) (diagnostic_information.hpp:123)
18:11:47 11: ==14654== by 0x404CAF5: std::string boost::diagnostic_information<std::exception>(std::exception const&, bool) (in /��BUILDDIR��/mir-0.20.0+16.04.20160219+vivid271bzr3133/obj-x86_64-linux-gnu/lib/libmirclient.so.9)
18:11:47 11: ==14654== by 0x40A04B9: mir_buffer_stream_swap_buffers (mir_buffer_stream_api.cpp:124)
18:11:47 11: ==14654== by 0x40A05CE: mir_buffer_stream_swap_buffers_sync (mir_buffer_stream_api.cpp:130)
18:11:47 11: ==14654== by 0x9356E9: ServerDisconnect_is_detected_by_client_Test::TestBody() (test_server_disconnect.cpp:89)

clang build is failing with:

11: ==14654== Invalid read of size 1
18:11:47 11: ==14654== at 0x4C2F122: strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
18:11:47 11: ==14654== by 0x7399E68: std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.20)
18:11:47 11: ==14654== by 0x404CE3A: boost::exception_detail::diagnostic_information_impl(boost::exception const*, std::exception const*, bool, bool) (diagnostic_information.hpp:157)
18:11:47 11: ==14654== by 0x404CAF5: std::string boost::diagnostic_information<std::exception>(std::exception const&, bool) (in /��BUILDDIR��/mir-0.20.0+16.04.20160219+vivid271bzr3133/obj-x86_64-linux-gnu/lib/libmirclient.so.9)
18:11:47 11: ==14654== by 0x40A04B9: mir_buffer_stream_swap_buffers (mir_buffer_stream_api.cpp:124)
18:11:47 11: ==14654== by 0x40A05CE: mir_buffer_stream_swap_buffers_sync (mir_buffer_stream_api.cpp:130)
18:11:47 11: ==14654== by 0x9356E9: ServerDisconnect_is_detected_by_client_Test::TestBody() (test_server_disconnect.cpp:89)
...
Address 0x121854c8 is 24 bytes inside a block of size 39 free'd
18:11:47 11: ==14654== at 0x4C2D2E0: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
18:11:47 11: ==14654== by 0x73B9862: std::future_error::what() const (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.20)
18:11:47 11: ==14654== by 0x404CC0A: boost::exception_detail::diagnostic_information_impl(boost::exception const*, std::exception const*, bool, bool) (diagnostic_information.hpp:123)
18:11:47 11: ==14654== by 0x404CAF5: std::string boost::diagnostic_information<std::exception>(std::exception const&, bool) (in /��BUILDDIR��/mir-0.20.0+16.04.20160219+vivid271bzr3133/obj-x86_64-linux-gnu/lib/libmirclient.so.9)
18:11:47 11: ==14654== by 0x40A04B9: mir_buffer_stream_swap_buffers (mir_buffer_stream_api.cpp:124)
18:11:47 11: ==14654== by 0x40A05CE: mir_buffer_stream_swap_buffers_sync (mir_buffer_stream_api.cpp:130)
18:11:47 11: ==14654== by 0x9356E9: ServerDisconnect_is_detected_by_client_Test::TestBody() (test_server_disconnect.cpp:89)

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-02-29:

#

@Alexandros, thanks.

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-02-29:

#

fix is an educated guess... can't quite figure out how to get clang to build (seems xenial is broken)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-29:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/444/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-03-01:

#

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/461/rebuild

review: Approve (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-03-02:

#

> The changes to "SurfaceScaling.compositor_sees_size_different_when_scaled" fit
> the name, but...
>
> ...it appears to remove a hidden test that should be called
> "SurfaceScaling.when_not_scaled_compositor_sees_same_size"
>
> Have I misunderstood the test, or has the functionality changed? (And is the
> change important?)

That test isn't changing in this MP.

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-03-02:

#

> > The changes to "SurfaceScaling.compositor_sees_size_different_when_scaled"
> fit
> > the name, but...
> >
> > ...it appears to remove a hidden test that should be called
> > "SurfaceScaling.when_not_scaled_compositor_sees_same_size"
> >
> > Have I misunderstood the test, or has the functionality changed? (And is the
> > change important?)
>
> That test isn't changing in this MP.

Oh, yes it is! See: === modified file 'tests/acceptance-tests/test_client_scaling.cpp'

Revision history for this message

Kevin DuBois (kdub) wrote on 2016-03-02:

#

ah, oops, searching for the test name doesnt work if the name isn't part of the diff context.

It's loosening an expectation that was unnecessary for the feature requirement. The old system would have to swap_buffers twice before the server would see a scaled size (once to flush the old-scaled buffer out, a second time to produce the new-scaled buffer), and the new system can immediately allocate a new-scaled buffer during mir_buffer_set_scale(), and produce the properly sized buffer on the 1st swap buffers call following the re-scaling.

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-03-02:

#

OK

review: Approve

Mir

Merge lp://qastaging/~kdub/mir/cover-nbs-with-acceptance-tests into lp://qastaging/mir

Commit message

Description of the change

Preview Diff

Subscribers