Merge lp://qastaging/~kdub/mir/fix-1413211 into lp://qastaging/mir
Proposed by
Kevin DuBois
Status: | Merged |
---|---|
Approved by: | Alan Griffiths |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2302 |
Proposed branch: | lp://qastaging/~kdub/mir/fix-1413211 |
Merge into: | lp://qastaging/mir |
Diff against target: |
88 lines (+29/-21) 3 files modified
src/server/graphics/software_cursor.cpp (+8/-20) src/server/graphics/software_cursor.h (+1/-1) tests/unit-tests/graphics/test_software_cursor.cpp (+20/-0) |
To merge this branch: | bzr merge lp://qastaging/~kdub/mir/fix-1413211 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alan Griffiths | Approve | ||
Daniel van Vugt | Abstain | ||
Alexandros Frantzis (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Ensure that mg::Buffer::write won't block when writing the SoftwareCursor by allocating a fresh buffer each time an update is needed.
fixes: LP: #1413211
Description of the change
Ensure that mg::Buffer::write won't block when writing the SoftwareCursor by allocating a fresh buffer each time an update is needed.
fixes: LP: #1413211
This seemed like the least obtrusive fix for this problem. Basically, the mg::Buffer::write() to update pixel contents was blocking because the cursor was always onscreen, and there wasn't an opportunity to write to the buffer.
To post a comment you must log in.
The same bugs exist for touchspots and other overlays. Shouldn't we be fixing this in some common code?
The bug description is certainly generalised, so if we do just fix it for software cursor, then this is not a fix for the attached bug. Call it a partial workaround and keep the bug open?