Merge lp://qastaging/~kdub/mir/fix-1635273 into lp://qastaging/mir
Proposed by
Kevin DuBois
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Daniel van Vugt | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 3784 | ||||
| Proposed branch: | lp://qastaging/~kdub/mir/fix-1635273 | ||||
| Merge into: | lp://qastaging/mir | ||||
| Diff against target: |
15 lines (+1/-1) 1 file modified
examples/multi_stream.cpp (+1/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~kdub/mir/fix-1635273 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mir CI Bot | continuous-integration | Approve | |
| Daniel van Vugt | Approve | ||
| Cemil Azizoglu (community) | Approve | ||
| Alan Griffiths | Approve | ||
| Alexandros Frantzis (community) | Approve | ||
|
Review via email:
|
|||
Commit message
examples: fix flickering that could be seen in mir_demo_
fixes: LP: #1635273
Description of the change
examples: fix flickering that could be seen in mir_demo_
fixes: LP: #1635273
The client was applying the multistream spec, then swapping buffers on a newly-created stream.
This gave a racy chance that the server would trigger a render before the newly created stream would post the buffer via swapbuffers. The server would then generate the renderable list without that stream (no posted frame), so it would look like flickering.
To post a comment you must log in.
Revision history for this message
| Mir CI Bot (mir-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
Revision history for this message
| Mir CI Bot (mir-ci-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good.