Unity

Merge lp://qastaging/~kees/unity/state-machine into lp://qastaging/unity

Proposed by Kees Cook on 2011-07-07

Status:	Rejected
Rejected by:	Jason Smith on 2011-09-23
Proposed branch:	lp://qastaging/~kees/unity/state-machine
Merge into:	lp://qastaging/unity
Diff against target:	550 lines (+308/-0) 5 files modified plugins/unityshell/src/GeisAdapter.cpp (+257/-0) plugins/unityshell/src/GeisAdapter.h (+16/-0) plugins/unityshell/src/PluginAdapter.cpp (+21/-0) plugins/unityshell/src/PluginAdapter.h (+3/-0) plugins/unityshell/src/unityshell.cpp (+11/-0)
To merge this branch:	bzr merge lp://qastaging/~kees/unity/state-machine
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Jason Smith (community)	2011-07-12	Needs Fixing on 2011-08-19
Chase Douglas	2011-07-07	Pending
Review via email: mp+67251@code.qastaging.launchpad.net

Note that this doesn't inhibit other drags (i.e. ginn still works with 2-finger drags).

Revision history for this message

Jason Smith (jassmith) wrote on 2011-08-19:

This breaks other applications using 2 finger gestures, of which there are currently none but I think we might get in trouble for that :/

review: Needs Fixing

Revision history for this message

Kees Cook (kees) wrote on 2011-08-19:

Hrm? But... it doesn't. I explicitly tested that since Chase brought that up as a potential problem.

1269. By Kees Cook on 2011-07-07: Attach to optional plugin and add gesture state machine for activation.
1268. By Kees Cook on 2011-07-06: Make the individual touch points from a gesture available to the Unity
gesture subsystem.