Merge lp://qastaging/~kejun-zhou/lava-android-test/ime into lp://qastaging/lava-android-test

Proposed by Yongqin Liu
Status: Superseded
Proposed branch: lp://qastaging/~kejun-zhou/lava-android-test/ime
Merge into: lp://qastaging/lava-android-test
Diff against target: 79 lines (+61/-0)
3 files modified
MANIFEST.in (+1/-0)
lava_android_test/test_definitions/ime.py (+47/-0)
lava_android_test/test_definitions/ime/ime_test.sh (+13/-0)
To merge this branch: bzr merge lp://qastaging/~kejun-zhou/lava-android-test/ime
Reviewer Review Type Date Requested Status
Le Chi Thu (community) Needs Fixing
Yongqin Liu Needs Fixing
Kejun ZHOU Pending
Review via email: mp+103465@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-05-23.

Description of the change

add test script wrapper for input method test

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

68 + echo "ime = pass"

this line seems not match the pattern defined in
43 +PATTERN = "^\s*(?P<test_case_id>\w+)=(?P<result>\w+)\s*$"

I think you can change to [echo "ime=pass"]

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

also, you should modify MANIFEST.in file

review: Needs Fixing
149. By Ke Jun ZHOU <dp583@stebjsxu0119>

[update]for inputmethod service

150. By Ke Jun ZHOU <dp583@stebjsxu0119>

update

Revision history for this message
Le Chi Thu (le-chi-thu) wrote :

Please describe the purpose of this test and what the test perform. Which input is required and expect conditions /outputs to detect when the test is pass or not.

echo "ime=unexist" should be echo "ime=fail"

review: Needs Fixing
151. By Ke Jun ZHOU <dp583@stebjsxu0119>

Change the lava_android_test/test_definitions/ime/ime_test.sh
-echo "ime=unexist"
+echo "ime=fail"

Revision history for this message
Le Chi Thu (le-chi-thu) wrote :

Please describe the purpose of this test and what the test perform. Which input is required and expect conditions /outputs to detect when the test is pass or not.

review: Needs Fixing
152. By Ke Jun ZHOU <dp583@stebjsxu0119>

Change imp.py to:
PATTERN = "^\s*(?P<test_case_id>ime)=(?P<result>\w+)\s*$"

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches