Compiz

Merge lp://qastaging/~ken-vandine/compiz/0.9.9.fix_1165343 into lp://qastaging/compiz/0.9.9

  1. 0.9.9.fix_1165343
  2. Merge into 0.9.9
Proposed by Ken VanDine
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3652
Merged at revision: 3650
Proposed branch: lp://qastaging/~ken-vandine/compiz/0.9.9.fix_1165343
Merge into: lp://qastaging/compiz/0.9.9
Diff against target: 493 lines (+102/-312)
5 files modified
debian/changelog (+9/-0)
plugins/place/src/constrain-to-workarea/include/constrain-to-workarea.h (+0/-6)
plugins/place/src/constrain-to-workarea/src/constrain-to-workarea.cpp (+5/-62)
plugins/place/src/constrain-to-workarea/tests/constrain-to-workarea/src/test-place-constrain-to-workarea.cpp (+58/-235)
plugins/place/src/place.cpp (+30/-9)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/compiz/0.9.9.fix_1165343
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Łukasz Zemczak Approve
Review via email: mp+159412@code.qastaging.launchpad.net

Commit message

Revert 3636 from lp:compiz/0.9.9 to fix Qt apps getting window decorations placed behind the panel. (LP: #1165343)
 * This reintroduces bug 1159324, Guake window appears placed by offset non-existent decoration

Description of the change

Revert 3636 from lp:compiz/0.9.9 to fix Qt apps getting window decorations placed behind the panel. (LP: #1165343)
 * This reintroduces bug 1159324, Guake window appears placed by offset non-existent decoration

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Base revert LGTM. +1

review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Lets do this for now - I have an idea on how to handle this problem but it needs time for QA.

review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Actually, back to NR, kenvandine needs to remove the visible check.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

and back.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3651
http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-raring-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-raring-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-raring-i386-ci/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/173

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-0.9.9-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches