Merge lp://qastaging/~ken-vandine/dee/install-gi-override into lp://qastaging/dee
Proposed by
Ken VanDine
| Status: | Rejected |
|---|---|
| Rejected by: | Mikkel Kamstrup Erlandsen |
| Proposed branch: | lp://qastaging/~ken-vandine/dee/install-gi-override |
| Merge into: | lp://qastaging/dee |
| Diff against target: |
51 lines (+15/-1) 4 files modified
Makefile.am (+1/-1) bindings/Makefile.am (+1/-0) bindings/python/Makefile.am (+9/-0) configure.ac (+4/-0) |
| To merge this branch: | bzr merge lp://qastaging/~ken-vandine/dee/install-gi-override |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Install the gi.override for python
To post a comment you must log in.
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | # |
Unmerged revisions
- 225. By Ken VanDine
-
Install Dee.py in gi.overrides
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
review needsfixing
Looks good. Can I get you to add a pkg-config check for 'python' and
make Python support optional? I am not overly keen on a harddep on
Python.