Online Accounts: GNOME Control Center

Merge lp://qastaging/~ken-vandine/gnome-control-center-signon/fixed_paths into lp://qastaging/gnome-control-center-signon

  1. fixed_paths
  2. Merge into trunk
Proposed by Ken VanDine
Status: Rejected
Rejected by: David King
Proposed branch: lp://qastaging/~ken-vandine/gnome-control-center-signon/fixed_paths
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 32 lines (+4/-1)
2 files modified
Makefile.am (+1/-1)
configure.ac (+3/-0)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/gnome-control-center-signon/fixed_paths
Reviewer Review Type Date Requested Status
David King (community) Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+134206@code.qastaging.launchpad.net

Description of the change

Fixed path in dbus service file

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:124
http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/65/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/./label=quantal/65/console

review: Needs Fixing (continuous-integration)
Revision history for this message
David King (amigadave) wrote :

The Makefile.am change is fine, thanks for noticing that.

However, the configure.ac change is both unnecessary and would never have worked anyway. SERVICE_EXECUTABLE is not used in Makefile.am, except in the substitution string @SERVICE_EXECUTABLE@, which is completely unrelated in this case. Remove the Makefile.am changes and then this seems fine.

review: Needs Fixing
Revision history for this message
David King (amigadave) wrote :

> Remove the Makefile.am changes and then this seems fine.

Oops, I meant configure.ac, not Makefile.am.

Revision history for this message
David King (amigadave) wrote :

I filed a bug:

https://bugs.launchpad.net/online-accounts-gnome-control-center/+bug/1078652

and folded the fix into another merge proposal:

https://code.launchpad.net/~amigadave/online-accounts-gnome-control-center/standalone-preferences/+merge/134278

review: Disapprove

Unmerged revisions

124. By Ken VanDine

Fixed path in dbus service file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: