Gwibber

Merge lp://qastaging/~ken-vandine/gwibber/lp_1058672 into lp://qastaging/gwibber/3.4

  1. lp_1058672
  2. Merge into 3.4
Proposed by Ken VanDine
Status: Needs review
Proposed branch: lp://qastaging/~ken-vandine/gwibber/lp_1058672
Merge into: lp://qastaging/gwibber/3.4
Diff against target: 21 lines (+2/-2)
1 file modified
gwibber/microblog/plugins/facebook/gtk/facebook/__init__.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/gwibber/lp_1058672
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+130377@code.qastaging.launchpad.net

Description of the change

Use webkit's onload-event instead of title changed to detect successful facebook login. Facebook changed the login_success.html file from html to plain text which does not have a title set. (LP: #1058672)

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Makes sense. The if "/login_success" in url bit makes me slightly nervous about false positives. It seems unlikely that /login_success would appear randomly, but... I dunno. /login_success?success=false maybe?

You know facebook's login better than me. If that's a bogus concern, go ahead. Else, approved with that fixed if it is a real concern.

review: Approve
Reply

Unmerged revisions

1321. By Ken VanDine

Use webkit's onload-event instead of title changed to
detect successful facebook login. Facebook changed
the login_success.html file from html to plain text
which does not have a title set. (LP: #1058672)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches