Merge lp://qastaging/~ken-vandine/libunity/social_preview into lp://qastaging/libunity
Proposed by
Ken VanDine
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Paweł Stołowski | ||||
| Approved revision: | 178 | ||||
| Merged at revision: | 176 | ||||
| Proposed branch: | lp://qastaging/~ken-vandine/libunity/social_preview | ||||
| Merge into: | lp://qastaging/libunity | ||||
| Diff against target: |
258 lines (+177/-4) 4 files modified
protocol/protocol-previews.vala (+96/-0) src/unity-previews.vala (+55/-0) test/vala/test-previews.vala (+21/-0) tools/preview-renderer.vala (+5/-4) |
||||
| To merge this branch: | bzr merge lp://qastaging/~ken-vandine/libunity/social_preview | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paweł Stołowski (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added SocialPreview
Description of the change
Added SocialPreview
To post a comment you must log in.
Revision history for this message
| Ken VanDine (ken-vandine) wrote | # |
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking good overall. Two remarks:
1) Can you add a simple serialization test to test-previews.vala?
2) This should be removed?:
176 +
177 +/* KEN
178 + public SocialPreview (Comment[] comments, string selected_item_uri)
179 + {
180 + // careful current_item_uri will be set before items are
181 + Object (current_item_uri: selected_item_uri);
182 + foreach (unowned Comment comment in comments)
183 + {
184 + add_comment (comment);
185 + }
186 + }
187 +*/