Merge lp://qastaging/~ken-vandine/ubuntu-system-settings/devModeVisibility into lp://qastaging/ubuntu-system-settings

Proposed by Ken VanDine
Status: Superseded
Proposed branch: lp://qastaging/~ken-vandine/ubuntu-system-settings/devModeVisibility
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 93 lines (+17/-2)
5 files modified
debian/control (+2/-2)
plugins/about/PageComponent.qml (+1/-0)
plugins/about/storageabout.cpp (+9/-0)
plugins/about/storageabout.h (+4/-0)
plugins/flight-mode/flight-mode.settings (+1/-0)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/ubuntu-system-settings/devModeVisibility
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Jonas G. Drange (community) Approve
Review via email: mp+306338@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2016-09-22.

Commit message

Only show Developer Mode setting if we can set it. Dropped dbus-property-service to suggests.

Description of the change

Only show Developer Mode setting if we can set it. Dropped dbus-property-service to suggests.

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM, thanks

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1721
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/158/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1592/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1592
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1440/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1440/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1440/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1440/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1440/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1440/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1440
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1440/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1440/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1440/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/158/rebuild

review: Needs Fixing (continuous-integration)
1722. By Ken VanDine

merged urfkill branch

1723. By Ken VanDine

merged prereq

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches