ubuntu-system-settings

Merge lp://qastaging/~ken-vandine/ubuntu-system-settings/haptic_entry_component into lp://qastaging/ubuntu-system-settings

  1. haptic_entry_component
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1622
Merged at revision: 1627
Proposed branch: lp://qastaging/~ken-vandine/ubuntu-system-settings/haptic_entry_component
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 23 lines (+2/-0)
2 files modified
src/qml/CategoryGrid.qml (+1/-0)
src/qml/UncategorizedItemsView.qml (+1/-0)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/ubuntu-system-settings/haptic_entry_component
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+289817@code.qastaging.launchpad.net

Commit message

Play haptic feedback when selecting About and Reset from the main view.

Description of the change

Play haptic feedback when selecting About and Reset from the main view.

To post a comment you must log in.
lp://qastaging/~ken-vandine/ubuntu-system-settings/haptic_entry_component updated
1622. By Ken VanDine

Handle the Haptics.play in the UncategorizedItemsView and CategoryGrid instead of in the plugin themselves

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

If the AbstractButton's click is eaten, do we know Haptics.play is the only thing we need to do?

review: Needs Information
Revision history for this message
Ken VanDine (ken-vandine) wrote :

> If the AbstractButton's click is eaten, do we know Haptics.play is the only
> thing we need to do?

I don't know what else we would need to do. We push the page properly on click, this ensures we play the haptic feedback whenever we need to push a PageComponent.

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

WFM! Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches