ubuntu-system-settings

Merge lp://qastaging/~ken-vandine/ubuntu-system-settings/recommend_accounts into lp://qastaging/ubuntu-system-settings

  1. recommend_accounts
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 67
Merged at revision: 67
Proposed branch: lp://qastaging/~ken-vandine/ubuntu-system-settings/recommend_accounts
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 12 lines (+2/-1)
1 file modified
debian/control (+2/-1)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/ubuntu-system-settings/recommend_accounts
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+170599@code.qastaging.launchpad.net

Commit message

Added a recommends for ubuntu-system-settings-online-accounts

Description of the change

Added a recommends for ubuntu-system-settings-online-accounts

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:67
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-saucy-amd64-ci/35

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-system-settings-ci/35/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

looks good, thanks Ken ... does the touch image pulls recommends by default? (I'm not sure)

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

On Thu, Jun 20, 2013 at 01:15:57PM -0000, Sebastien Bacher wrote:
> Review: Approve
>
> looks good, thanks Ken ... does the touch image pulls recommends by default? (I'm not sure)

I had an apt.conf.d snippet to disable them, so I guess not.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Ken VanDine (ken-vandine) wrote :

It doesn't pull recommends, we'll seed online-accounts itself. But the recommends seemed like the right thing to do in general.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches