ubuntu-system-settings

Merge lp://qastaging/~ken-vandine/ubuntu-system-settings/rtm-lp1336715.check.sync into lp://qastaging/ubuntu-system-settings/rtm-14.09

  1. rtm-lp1336715.check.sync
  2. Merge into rtm-14.09
Proposed by Ken VanDine
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 936
Merged at revision: 936
Proposed branch: lp://qastaging/~ken-vandine/ubuntu-system-settings/rtm-lp1336715.check.sync
Merge into: lp://qastaging/ubuntu-system-settings/rtm-14.09
Diff against target: 645 lines (+157/-134)
15 files modified
plugins/battery/PageComponent.qml (+14/-25)
plugins/bluetooth/PageComponent.qml (+9/-15)
plugins/brightness/PageComponent.qml (+4/-9)
plugins/cellular/Components/CellularMultiSim.qml (+8/-8)
plugins/cellular/Components/CellularSingleSim.qml (+4/-2)
plugins/flight-mode/EntryComponent.qml (+3/-3)
plugins/language/PageComponent.qml (+28/-21)
plugins/language/SpellChecking.qml (+12/-3)
plugins/orientation-lock/EntryComponent.qml (+6/-4)
plugins/phone/PageComponent.qml (+4/-2)
plugins/security-privacy/PageComponent.qml (+8/-14)
plugins/security-privacy/PhoneLocking.qml (+10/-4)
plugins/sound/PageComponent.qml (+28/-15)
plugins/sound/sound.cpp (+3/-0)
plugins/wifi/MenuItemFactory.qml (+16/-9)
To merge this branch: bzr merge lp://qastaging/~ken-vandine/ubuntu-system-settings/rtm-lp1336715.check.sync
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
Sebastien Bacher (community) Approve
Review via email: mp+241360@code.qastaging.launchpad.net

Commit message

Backport fix for Switch/Check binding (LP: #1336715)

Description of the change

Backport fix for Switch/Check binding (LP: #1336715)

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks bug #1390643 suggest those changes are buggy/not working as they should. E.g the orientation lock binding is undone when clicking on the widget and stops following the backend value changes then

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

in fact the other bug is in rtm which doesn't have those changes yet, guess we should just land that and revisit how things are working ;-)

review: Approve
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Regarding the porting from trunk issue you mentioned on IRC: Unless I've totally missed something, it looks like you've ported the cell changes correctly.

review: Approve
lp://qastaging/~ken-vandine/ubuntu-system-settings/rtm-lp1336715.check.sync updated
937. By Ken VanDine

Binding for data roaming switch

938. By Ken VanDine

Revert adding Binding for data roaming, just needed to fix reference to poweredSim

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches