U1DB Qt/ QML

Merge lp://qastaging/~kevin-wright-1/u1db-qt/document-april-6-i into lp://qastaging/u1db-qt

  1. document-april-6-i
  2. Merge into trunk
Proposed by Cris Dywan
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp://qastaging/~kevin-wright-1/u1db-qt/document-april-6-i
Merge into: lp://qastaging/u1db-qt
Diff against target: 109 lines (+44/-2)
3 files modified
database.cpp (+1/-0)
document.cpp (+38/-2)
document.h (+5/-0)
To merge this branch: bzr merge lp://qastaging/~kevin-wright-1/u1db-qt/document-april-6-i
Reviewer Review Type Date Requested Status
Cris Dywan Disapprove
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+157621@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-04-06.

Description of the change

"Added a 'revise' property to Document and accompanying functionality that provides the ability to modify existing documents in the database (if the docId already exists).

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:64
http://91.189.93.125:8080/job/u1db-qt-ci/21/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/u1db-qt-quantal-amd64-ci/21
    SUCCESS: http://91.189.93.125:8080/job/u1db-qt-raring-amd64-ci/21

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/u1db-qt-ci/21/rebuild

review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote : Posted in a previous version of this proposal

I'm unsure of the 'revise' functionality, it looks to do mostly what I *intended* 'create' for, *maybe* hinting at a bug in existing code. I'll prefer to discuss this in detail before making a decision.

review: Needs Information
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:64
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~kevin-wright-1/u1db-qt/document-april-6-i/+merge/157621/+edit-commit-message

http://91.189.93.125:8080/job/u1db-qt-ci/28/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/u1db-qt-quantal-amd64-ci/28
    SUCCESS: http://91.189.93.125:8080/job/u1db-qt-raring-amd64-ci/28

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/u1db-qt-ci/28/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

For the record: as discussed, the extra API isn't needed. 'contents' should be used instead.

review: Disapprove

Unmerged revisions

64. By Kevin Wright

Added a 'revise' property to Document and accompanying functionality that provides the abilty to modify existing documents in the database (if the docId already exists).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: