Merge lp://qastaging/~kevin-wright-1/u1db-qt/documentation-examples-april-9-2013-i into lp://qastaging/u1db-qt

Proposed by Cris Dywan
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp://qastaging/~kevin-wright-1/u1db-qt/documentation-examples-april-9-2013-i
Merge into: lp://qastaging/u1db-qt
Diff against target: 2143 lines (+1578/-380) (has conflicts)
21 files modified
CMakeLists.txt (+10/-10)
document.cpp (+0/-205)
document.h (+0/-77)
documentation/u1db.qdocconf (+7/-7)
examples/u1db-qt-example-5/u1db-qt-example-5-qml.qdoc (+129/-0)
examples/u1db-qt-example-5/u1db-qt-example-5.qdoc (+1/-4)
examples/u1db-qt-example-5/u1db-qt-example-5.qml (+1/-1)
global.h (+0/-52)
modules/U1db/plugin.cpp (+4/-4)
private.h (+0/-19)
src/database.cpp (+523/-0)
src/database.h (+76/-0)
src/document.cpp (+205/-0)
src/document.h (+77/-0)
src/global.h (+52/-0)
src/index.cpp (+149/-0)
src/index.h (+69/-0)
src/private.h (+19/-0)
src/query.cpp (+184/-0)
src/query.h (+71/-0)
tests/test-database.cpp (+1/-1)
Contents conflict in database.cpp
Contents conflict in database.h
Contents conflict in index.cpp
Contents conflict in index.h
Contents conflict in query.cpp
Contents conflict in query.h
To merge this branch: bzr merge lp://qastaging/~kevin-wright-1/u1db-qt/documentation-examples-april-9-2013-i
Reviewer Review Type Date Requested Status
Cris Dywan Disapprove
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+157873@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-04-09.

Commit message

Modified directory structure and build configuration to improve doc generation. Source and header files were moved into their own sub-directory (src), and appropriate modifications made to account for this (e.g. Cmake instructions etc.). Also made changes to some example / qdoc files to work around current limitations in the doc build (e.g. cross linking / referencing other files, such as source for examples, not working properly).

Description of the change

Modified directory structure and build configuration to improve doc generation. Source and header files were moved into their own sub-directory (src), and appropriate modifications made to account for this (e.g. Cmake instructions etc.). Also made changes to some example / qdoc files to work around current limitations in the doc build (e.g. cross linking / referencing other files, such as source for examples, not working properly).

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :
review: Disapprove

Unmerged revisions

71. By Kevin Wright

Added a qdoc file representing the qml code of example 5 (to work around current limitations in the doc configuration that doesn't build html files for example source.

70. By Kevin Wright

Modified directory structure and build configuration to improve doc generation. Source and header files were moved into their own sub-directory (src), and appropriate modifications made to account for this (e.g. Cmake instructions etc.). Also made changes to some example / qdoc files to work around current limitations in the doc build (e.g. cross linking / referencing other files, such as source for examples, not working properly).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: