Merge lp://qastaging/~kevin-wright-1/u1db-qt/index-query-april-5-i into lp://qastaging/u1db-qt

Proposed by Kevin Wright
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp://qastaging/~kevin-wright-1/u1db-qt/index-query-april-5-i
Merge into: lp://qastaging/u1db-qt
Diff against target: 510 lines (+349/-25)
5 files modified
examples/u1db-qt-example-5.qml (+167/-0)
index.cpp (+152/-1)
index.h (+8/-4)
query.cpp (+21/-15)
query.h (+1/-5)
To merge this branch: bzr merge lp://qastaging/~kevin-wright-1/u1db-qt/index-query-april-5-i
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+157369@code.qastaging.launchpad.net

Commit message

Created initial index functionality. Modified source for both Index and Query. Within the Index source, QVariantMaps are generated (based on the index expressions), using appropriate data, and put into a QList, which is used by Query::data as its return value. Some known issues: currently will match on any index expression criteria (rather than on all criteria), and will not recognize new databases / documents (but has no problems with existing ones).

Description of the change

Created initial index functionality. Modified source for both Index and Query. Within the Index source, QVariantMaps are generated (based on the index expressions), using appropriate data, and put into a QList, which is used by Query::data as its return value. Some known issues: currently will match on any index expression criteria (rather than on all criteria), and will not recognize new databases / documents (but has no problems with existing ones).

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Please make separate commits for a) the index.cpp code b) the example c) qdoc changes. I see different qdoc changes all over the place, some of which look wrong.

I can't break up the MR on my end unfortunately, so I'm marking this whole as Needs Fixing.

review: Needs Fixing

Unmerged revisions

61. By Kevin Wright

Created initial index functionality. Modified source for both Index and Query. Within the Index source, QVariantMaps are generated (based on the index expressions), using appropriate data, and put into a QList, which is used by Query::data as its return value. Some known issues: currently will match on any index expression criteria (rather than on all criteria), and will not recognize new databases / documents (but has no problems with existing ones).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: