U1DB Qt/ QML

Merge lp://qastaging/~kevin-wright-1/u1db-qt/index-query-april-5-iii into lp://qastaging/u1db-qt

  1. index-query-april-5-iii
  2. Merge into trunk
Proposed by Kevin Wright
Status: Merged
Approved by: Cris Dywan
Approved revision: 61
Merged at revision: 62
Proposed branch: lp://qastaging/~kevin-wright-1/u1db-qt/index-query-april-5-iii
Merge into: lp://qastaging/u1db-qt
Diff against target: 171 lines (+167/-0)
1 file modified
examples/u1db-qt-example-5.qml (+167/-0)
To merge this branch: bzr merge lp://qastaging/~kevin-wright-1/u1db-qt/index-query-april-5-iii
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+157498@code.qastaging.launchpad.net

Commit message

Created initial example to demonstrate index functionality.

Description of the change

Created initial example to demonstrate index functionality.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:61
http://91.189.93.125:8080/job/u1db-qt-ci/18/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/u1db-qt-quantal-amd64-ci/18
    SUCCESS: http://91.189.93.125:8080/job/u1db-qt-raring-amd64-ci/18

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/u1db-qt-ci/18/rebuild

review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Minor nitpick: helloListModel confused me while reviewing the code because it doesn't sound like the name of a Query to me. Not a big issue and not blocking the merger, though.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: