Merge lp://qastaging/~kevin-wright-1/u1db-qt/query-april-19-2013-i into lp://qastaging/u1db-qt

Proposed by Kevin Wright
Status: Merged
Approved by: Cris Dywan
Approved revision: 76
Merged at revision: 72
Proposed branch: lp://qastaging/~kevin-wright-1/u1db-qt/query-april-19-2013-i
Merge into: lp://qastaging/u1db-qt
Diff against target: 212 lines (+161/-5)
3 files modified
examples/u1db-qt-example-5/u1db-qt-example-5.qml (+1/-1)
src/query.cpp (+153/-4)
src/query.h (+7/-0)
To merge this branch: bzr merge lp://qastaging/~kevin-wright-1/u1db-qt/query-april-19-2013-i
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+159796@code.qastaging.launchpad.net

Commit message

Added support for 'Query' to use string, list or map. Removed 'queries' property.

Description of the change

Added support for 'Query' to use string, list or map. Removed 'queries' property.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
76. By Kevin Wright

Fixed u1db-qt-example-5.qml -- an incorrect modification was accidently pushed, where a query was designed to not return anything (which is fine for testing but not desireable for the example suite).

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Awesome stuff. Agreed on the API and did some manual functional testing, I will be adding test cases in a follow-up MR shortly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: