Application Menu Indicator

Merge lp://qastaging/~khurshid-alam/indicator-appmenu/fix-build-disco into lp://qastaging/indicator-appmenu

  1. fix-build-disco
  2. Merge into trunk.16.10
Proposed by Khurshid Alam
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 282
Merged at revision: 285
Proposed branch: lp://qastaging/~khurshid-alam/indicator-appmenu/fix-build-disco
Merge into: lp://qastaging/indicator-appmenu
Diff against target: 42 lines (+4/-4)
2 files modified
src/window-menu-dbusmenu.c (+2/-2)
src/window-menu-model.c (+2/-2)
To merge this branch: bzr merge lp://qastaging/~khurshid-alam/indicator-appmenu/fix-build-disco
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+361403@code.qastaging.launchpad.net

Commit message

src/window-menu-*.c: Type cast assignments from g_object_ref().

Description of the change

Note it fixes type cast errors, and doesn't fix ‘g_type_class_add_private’ is deprecated warnings. But it compiles on disco.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

I would prefer to use G_DBUS_MENU_MODEL(), while it might imply an uneeded check, is a bit more readable.

Anyway this is fine per se.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches