Ubuntu
ubuntu-settings package

Merge ~khurshid-alam/ubuntu/+source/ubuntu-settings:nemo-desktop into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

  1. Git
  2. lp:~khurshid-alam/ubuntu/+source/ubuntu-settings
  3. nemo-desktop
  4. Merge into master
Proposed by Khurshid Alam
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: f4917ddd7ae80c6e05a5509807fb20234466adb1
Merge reported by: Didier Roche-Tolomelli
Merged at revision: f4917ddd7ae80c6e05a5509807fb20234466adb1
Proposed branch: ~khurshid-alam/ubuntu/+source/ubuntu-settings:nemo-desktop
Merge into: ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Diff against target: 15 lines (+4/-0)
1 file modified
debian/ubuntu-settings.gsettings-override (+4/-0)
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+362663@code.qastaging.launchpad.net

Commit message

Use nemo-desktop to draw desktop icons under Unity. Fixes LP: #1814506

Since nautilus will still be default file-manager we disable auto-mount with nemo here.

Description of the change

Nemo action files

1) Adds a context menu "change background" which opens unity-control-center-appearance.

2) When user clicks on a image on Desktop, it adds a context menu set as wallpaper.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The settings override is the correct place for this. However, I feel the autostart for nemo doesn't belong here.
Especially, this would be installed in every ubuntu installation, and we don't really want it.

I think this should rather be in the unity-session package. WDYT?

review: Needs Fixing
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

unity-session derives from gnome-session. Would that be ok ?

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Move from gnome-session to unity? If unity-session would be part of unity then it might be easier to update things, no? Now it it looks like you have make changes in many/multiple places and in the end these changes makes sense only if unity is installed.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

@didrocks

Ah, I see, you are talking about unity-session install file. Yes it seems more appropriate.

I have now moved autostart and action files to unity-session install. See here https://code.launchpad.net/~khurshid-alam/ubuntu/+source/gnome-session/+git/gnome-session/+merge/363153

And I force pushed this with only gsettings override.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

@muktupavels

I will try to decouple unity-session and other unity components next cycle. But other unity components should move to git first, so that our ubuntu-unity seed can work without breaking things.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

+1 LGTM. I'll give a build test and sponsor

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

This is now merged. Unfortunately, I didn't notice that you changed the branch and kept your master with the actions. So, I just did another upload (19.04.2) to remove those.
Marking as merged manually thus! Thanks for this.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Yes I forgot to delete the master branch. I just made that for ppa. But Thanks for fixing that.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches