Merge lp://qastaging/~kim0/pyjuju/adding-hook-traces-to-readme-for-bashified-example into lp://qastaging/~jimbaker/pyjuju/bashified-wordpress-mysql-examples
Proposed by
Ahmed Kamal
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~kim0/pyjuju/adding-hook-traces-to-readme-for-bashified-example |
| Merge into: | lp://qastaging/~jimbaker/pyjuju/bashified-wordpress-mysql-examples |
| Diff against target: |
55 lines (+32/-2) 1 file modified
examples/readme.txt (+32/-2) |
| To merge this branch: | bzr merge lp://qastaging/~kim0/pyjuju/adding-hook-traces-to-readme-for-bashified-example |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Niemeyer (community) | Disapprove | ||
| Jim Baker | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Gustavo Niemeyer (niemeyer) wrote | # |
Revision history for this message
| Gustavo Niemeyer (niemeyer) | # |
review:
Disapprove
Unmerged revisions
- 188. By Ahmed Kamal
-
Updating hook trace, changed always gets fired after joined
- 187. By Ahmed Kamal
-
Fixing docs to match hook changes (joined)
- 186. By Ahmed Kamal
-
Adding a sample hook execution trace to readme to better understand execution dynamics
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
That's a nice way to visualize the communication, but there's a small issue
related to one of the hooks:
[1]
+ mysql/0(
The mysql formula doesn't have the db-relation-changed hook, and has the db-relation-joined one.