Merge lp://qastaging/~kim0/pyjuju/adding-hook-traces-to-readme-for-bashified-example into lp://qastaging/pyjuju

Proposed by Ahmed Kamal
Status: Work in progress
Proposed branch: lp://qastaging/~kim0/pyjuju/adding-hook-traces-to-readme-for-bashified-example
Merge into: lp://qastaging/pyjuju
Diff against target: 55 lines (+32/-2)
1 file modified
examples/readme.txt (+32/-2)
To merge this branch: bzr merge lp://qastaging/~kim0/pyjuju/adding-hook-traces-to-readme-for-bashified-example
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
William Reade (community) Approve
Review via email: mp+62537@code.qastaging.launchpad.net

Description of the change

Fixed docs to match hook changes (joined instead of changed) and new execution order

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Excerpts from Ahmed Kamal's message of Thu May 26 18:51:41 UTC 2011:
> Ahmed Kamal has proposed merging lp:~kim0/ensemble/adding-hook-traces-to-readme-for-bashified-example into lp:ensemble.
>
> Requested reviews:
> Ensemble Team (ensemble)
>
> For more details, see:
> https://code.launchpad.net/~kim0/ensemble/adding-hook-traces-to-readme-for-bashified-example/+merge/62537
>
> Fixed docs to match hook changes (joined instead of changed) and new execution order

Thanks again, for working on the documentation. Looks good but there are some errors in the traces.

There is no ensemble 'established' hook for relations. Instead we have joined called, all joines
are followed by a changed invocation (independent of if there is an actual change subsequent to
the join). All subsequent change invocations are due to changes in the related units.

188. By Ahmed Kamal

Updating hook trace, changed always gets fired after joined

Revision history for this message
Ahmed Kamal (kim0) wrote :

Just pushed fixed docs, let me know if that looks good

Revision history for this message
William Reade (fwereade) wrote :

I'd prefer it if there were a little more distinction between the explanatory comments and the actual hooks which are firing, but this is still useful information and I can't see any drawback to adding it.

review: Approve
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

lgtm as well

review: Approve
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

This was created before config-changed, I just realized. So it needs to be updated before merging to reflect when config-changed is run as well.

review: Needs Fixing

Unmerged revisions

188. By Ahmed Kamal

Updating hook trace, changed always gets fired after joined

187. By Ahmed Kamal

Fixing docs to match hook changes (joined)

186. By Ahmed Kamal

Adding a sample hook execution trace to readme to better understand execution dynamics

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: