Merge ~kissiel/checkbox/+git/checkbox-configure:qol-changes into ~checkbox-dev/checkbox/+git/checkbox-configure:master

Proposed by Maciej Kisielewski
Status: Needs review
Proposed branch: ~kissiel/checkbox/+git/checkbox-configure:qol-changes
Merge into: ~checkbox-dev/checkbox/+git/checkbox-configure:master
Diff against target: 393 lines (+234/-58)
5 files modified
README.md (+154/-0)
configure.ac (+75/-56)
launchers/wrapper_local.in (+2/-1)
launchers/wrapper_local.in_classic (+2/-0)
launchers_v2/wrapper_local.in (+1/-1)
Reviewer Review Type Date Requested Status
Pierre Equoy Needs Fixing
Review via email: mp+409578@code.qastaging.launchpad.net

Description of the change

This patchset brings some quality of life improvements to checkbox-configure.

See individual commit messages for details.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

I fixed a problem with generating classic snap with embedded provider.
Squashed and pushed.

Revision history for this message
Pierre Equoy (pieq) wrote :

I added a few comments inline.

In addition, I played a little with this tool (one of the project I have requires the creation of checkbox snaps). When I run:

    ./configure project=test base=core20

it does a bunch of things, and then:

-----------------------------------
$ tree checkbox-test
checkbox-test
├── config
│   └── config_vars
├── launchers
│   ├── checkbox-cli-wrapper
│   ├── configure
│   ├── shell-wrapper
│   ├── test-runner
│   ├── test-runner-automated
│   └── wrapper_local
├── README.md
└── snap
    ├── hooks
    │   ├── configure
    │   └── install
    ├── plugins
    │   └── checkbox_provider.py
    ├── snapcraft_classic.yaml.in_v2
    └── snapcraft.yaml

5 directories, 13 files
-----------------------------------

→ is the `snapcraft_classic.yaml.in_v2` file expected here? How about `README.md`?

-----------------------------------
$ tree checkbox-test-classic/
checkbox-test-classic/
├── checkbox-provider-template
│   └── units
│   └── device
│   └── jobs.pxu
├── config
│   └── config_vars
├── launchers
│   ├── checkbox-cli-wrapper
│   ├── checkbox-slave
│   ├── configure
│   ├── hook-wrapper
│   ├── shell-wrapper
│   ├── test-runner
│   ├── test-runner-automated
│   └── wrapper_local
├── launchers_v2
│   ├── checkbox-cli-wrapper
│   ├── configure.in_classic
│   ├── shell-wrapper
│   ├── test-runner-automated.in
│   ├── test-runner-automated.in_classic
│   ├── test-runner.in
│   ├── test-runner.in_classic
│   ├── wrapper_local.in
│   └── wrapper_local.in_classic
├── README.md
└── snap
    ├── hooks
    │   ├── configure
    │   ├── install
    │   └── remove
    ├── plugins
    │   └── checkbox_provider.py
    ├── snapcraft.yaml
    └── snapcraft.yaml.in_v2

9 directories, 26 files
-----------------------------------

→ Looks like a lot of files have been copied over, but I'm not sure if that's normal:

- launchers_v2/*
- README.md
- snap/snapcraft.yaml.in_v2

review: Needs Fixing
Revision history for this message
Maciej Kisielewski (kissiel) wrote (last edit ):

I've fixed the problems listed by Pierre. Squashed and pushed.

Revision history for this message
Pierre Equoy (pieq) wrote :

Thanks for fixing these! It works better now :)

I noticed (only now, sorry!) that the markdown syntax was a bit off. Copypasting the README file in StackEdit for instance does not lead to a good HTML markup. I added some inline comments, but this happens eslewhere in the doc. Basically, syntax like

``` blablabla ```

should become

```
blablabla
```

otherwise it's not converted to a code block, but in an inline element in HTML.

Also, there is a reference to an internal project, I guess that should be removed (it's not useful for the understanding of the line anyway).

review: Needs Fixing

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches