Checkbox

Merge ~kissiel/checkbox/+git/support:parallel-test-in-lxc into ~checkbox-dev/checkbox/+git/support:master

  1. Git
  2. lp:~kissiel/checkbox/+git/support
  3. parallel-test-in-lxc
  4. Merge into master
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: e890e2a9e33d95dba171cdcb86b707ad8c9a5376
Merged at revision: 23604784b6d65ede9d845bd9e303e134e4bebcd1
Proposed branch: ~kissiel/checkbox/+git/support:parallel-test-in-lxc
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 45 lines (+15/-3)
1 file modified
test-in-lxc.sh (+15/-3)
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+336634@code.qastaging.launchpad.net

Description of the change

This MR makes test-in-lxc.sh run tests in parallel for each lxc-image.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Two questions, but overall +1 and very cool!
1. I don't recall from the demo, but does the output mixing cause any issues? I suspect not since we redirect the real output we care about to a file, but just checking
2. If I imagine looking at this without context, I don't that I would immediately understand what this is for. Can you add a small comment before that indicating that it's to run our lxc tests in parallel?

review: Approve
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> 1. I don't recall from the demo, but does the output mixing cause any issues?
> I suspect not since we redirect the real output we care about to a file, but
> just checking

Bash buffers stdout in with 4k pages, or until newline. The real log is pushed to pastebin, the
echo-ed lines are prepended by container (process) name, so I don't care :)
btw. "There are three Concurrency! hard things in Computer Science: cache invalidation, naming things, off by one errors, and"

> 2. If I imagine looking at this without context, I don't that I would
> immediately understand what this is for. Can you add a small comment before
> that indicating that it's to run our lxc tests in parallel?

Yes, Sir!
amended + repushed

Revision history for this message
Paul Larson (pwlars) wrote :

hah, nice :) +1

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches