Checkbox

Merge ~kissiel/checkbox/+git/support:add-bionic-to-test-in-lxc into ~checkbox-dev/checkbox/+git/support:master

  1. Git
  2. lp:~kissiel/checkbox/+git/support
  3. add-bionic-to-test-in-lxc
  4. Merge into master
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: 28330abc81c27b7d54e77b49825a1077672495b3
Merged at revision: 264a9f761127701fdcd25c7520943a9b1e976235
Proposed branch: ~kissiel/checkbox/+git/support:add-bionic-to-test-in-lxc
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 22 lines (+2/-2)
1 file modified
test-in-lxc.sh (+2/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+345512@code.qastaging.launchpad.net

Commit message

add bionic to test-in-lxc

The removed package "python-software-properties" was no longer needed in trusty and xenial, and is _not_ available for bionic.

Tested on virtual machines with both Xenial and Bionic (as the host).

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

We usually merge branches with pmr in 10m. Can you confirm that with 3 runs in lxc it's more or less 15m (not more)?

review: Needs Information
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> We usually merge branches with pmr in 10m. Can you confirm that with 3 runs in
> lxc it's more or less 15m (not more)?

Yes. It should actually be less than 50% additions due to less work needed to provision Bionic container.

I'll do another timing run and post scores in a bit.

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

TT + XX

real 7m17,652s
user 3m17,750s
sys 0m53,595s

TT + XX ++ BB

real 11m46,172s
user 5m0,371s
sys 1m19,881s

So roughly +60%. But it varies...

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches