Checkbox

Merge ~kissiel/checkbox/+git/support:benchmarking into ~checkbox-dev/checkbox/+git/support:master

  1. Git
  2. lp:~kissiel/checkbox/+git/support
  3. benchmarking
  4. Merge into master
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: 955e5d2ded1aa64d66368631b63fac4912c33c41
Merged at revision: 477542eac74af59b29ec1f560ed9c24ec13e33b4
Proposed branch: ~kissiel/checkbox/+git/support:benchmarking
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 140 lines (+134/-0)
1 file modified
benchmark.py (+134/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Maciej Kisielewski (community) Needs Resubmitting
Review via email: mp+377929@code.qastaging.launchpad.net

Description of the change

add benchmarking tool

To run the benchmark run ./benchmark.py proposed here.
This will create a temporary directory which will then get populated with a
virutalenv. On a decent, modern laptop it will take 15mins to complete.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

I pushed the provider to a separate repo here:
https://code.launchpad.net/~checkbox-dev/checkbox/+git/benchmarking-provider

And removed it from this `support` repo.

Now you have to clone the provider into the support dir with:
git clone https://code.launchpad.net/~checkbox-dev/checkbox/+git/benchmarking-provider

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

I think I would alter some of the directory changes slightly so that with a checkbox-ng tree I have been working on I can just call the benchmark script from somewhere else in file system:

checkbox-ng$ ~/path-to/support/benchmark.py

Comments below should be close to achieving this.

Could optionally do the clone of the provider automatically.

Make any sense?

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> Make any sense?
Yup :)

I've added a CLI argument and an option to make it less dir-dependant.

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

Much better IMO and a test of a local copy of checkbox-ng worked for me here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches