Merge ~kissiel/checkbox/+git/support:benchmarking-redux into ~checkbox-dev/checkbox/+git/support:master

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: b2916fc8c52c2f10771988f055ee3e7fedb74618
Merged at revision: d18981111f6ea15b9821ba26258577130c0cc294
Proposed branch: ~kissiel/checkbox/+git/support:benchmarking-redux
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 76 lines (+33/-3)
1 file modified
benchmark.py (+33/-3)
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Needs Resubmitting
Sheila Miguez (community) Approve
Review via email: mp+378619@code.qastaging.launchpad.net

Description of the change

Change the output so it matches what is needed in influx.

Namely, now the output includes:
* timestamp of the commit in nanoseconds
* commit hash
* ID of the system (if not supplied by the option the script will use cpu name from lscpu)
* results as influx's "fields"

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

It looks good. Did you consider using --short in the rev-parse command? That's the only thing I can think to say.

review: Approve
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

added --short to the revparse

squashed, pushed

review: Needs Resubmitting

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches