Merge lp://qastaging/~kissiel/checkbox/bootstrapping-include into lp://qastaging/checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 4004
Merged at revision: 4000
Proposed branch: lp://qastaging/~kissiel/checkbox/bootstrapping-include
Merge into: lp://qastaging/checkbox
Diff against target: 325 lines (+187/-7)
6 files modified
checkbox-touch/checkbox-touch.qml (+1/-0)
plainbox/docs/changelog.rst (+18/-2)
plainbox/docs/manpages/plainbox-test-plan-units.rst (+72/-0)
plainbox/plainbox/impl/session/assistant.py (+10/-5)
plainbox/plainbox/impl/unit/test_testplan.py (+28/-0)
plainbox/plainbox/impl/unit/testplan.py (+58/-0)
To merge this branch: bzr merge lp://qastaging/~kissiel/checkbox/bootstrapping-include
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+270035@code.qastaging.launchpad.net

Description of the change

This MR brings proper bootstrapping to the Session Assistant and therefore Checkbox-Converged.

d186e7b checkbox-touch: enable local jobs
efcc34c plainbox:unit:testplan: add get_bootstrap_job_ids method
2f97c46 plainbox:unit:testplan: add bootstrap_include field
eb37f39 plainbox:unit:testplan: add qualifier for pulling bootstrapping jobs
95438b4 plainbox:session:assistant: use test plan's bootstrap_include field
09bb92d plainbox:unit:testplan: add validators to the bootstrap_include field
0fdfd59 plainbox:docs:manpages: update test plan unit manpage
b00f39f plainbox:docs: update changelog

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

12:44 <@zyga> kissiel: bootstrap include is not a list of patterns
12:44 <@zyga> kissiel: construct a list of qualifiers that match against IDs

The reason for this is so that there is no ambiguity in what is selected and what the boostrap include section contains. We can perfectly validate that each entry corresponds to a job or that it is invalid.

review: Needs Fixing
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

TMWYT --- tell me what you think

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

16:00 <@zyga> kissiel: did you do the manual page changes?
16:00 < kissiel> ah, shoot

review: Needs Fixing
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Just a few small tweaks to docs, all the code is +1

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches