Merge lp://qastaging/~kissiel/checkbox/command-output-in-cbt into lp://qastaging/checkbox

13:10 <@zyga> kissiel: about http://bazaar.launchpad.net/~kissiel/checkbox/command-output-in-cbt/revision/3796
13:11 <@zyga> kissiel: && activity.running
13:11 < kissiel> yes?
13:11 <@zyga> kissiel: not sure what activity is there
13:11 <@zyga> kissiel: but will that hide the button when the test is ... finished?
13:11 < kissiel> zyga, activity is the spinner component
13:11 <@zyga> kissiel: ah, right
13:12 < kissiel> zyga, yes, it will get hidden, as the test will be ended
13:12 <@zyga> kissiel: so when I write a test "echo 'please fail this test'"
13:12 <@zyga> kissiel: that won't work ?
13:12 < kissiel> zyga, you won't be able to read the output in CBT
13:12 <@zyga> kissiel: I think we should let the user see the output then
13:12 <@zyga> kissiel: as many current tests do that
13:12 < kissiel> zyga, as it will blast right through
13:12 <@zyga> ah
13:12 <@zyga> right
13:12 <@zyga> this is for 'shell'
13:13 < kissiel> zyga, indeed it is
13:13 <@zyga> kissiel: sorry, then this is good :)
13:13 <@zyga> kissiel: so for verification, it will be visible normally, ok
13:13 < kissiel> zyga, no worries, I had the same concern
13:13 <@zyga> kissiel: btw, can you git push that somewhere
13:13 < kissiel> zyga, surely
13:13 <@zyga> kissiel: (lp preferrably)
13:13 <@zyga> kissiel: thanks, reading the rest
13:14 <@zyga> kissiel: http://bazaar.launchpad.net/~kissiel/checkbox/command-output-in-cbt/revision/3794
13:14 <@zyga> kissiel: I'd move that to one place, this makes the app. version pretty much broken
13:14 < kissiel> zyga, bleh, formatting
13:14 <@zyga> kissiel: no, I mean the extra fuction
13:14 <@zyga> kissiel: not the newline
13:15 < kissiel> zyga, I thought about renaming all back-end operations to "run_command"
13:15 < kissiel> zyga, to correspond to plainbox better
13:15 < kissiel> zyga, while qmly logic to use this nomenclature
13:15 < kissiel> zyga, you're worrying about scoping rules, right?
13:15 <@zyga> kissiel: I mean that if someone calls app.runTestActivity instead of the runTestActivity function they won't get the desired effect
13:15 <@zyga> kissiel: no, about this ^^
13:16 < kissiel> :)
13:17 < kissiel> zyga, hmm
13:17 < kissiel> zyga, well, that patch is stupid
13:17 < kissiel> zyga, I should clear the text area whenever new test is started
13:17 < kissiel> zyga, and that's it :D
13:17 <@zyga> kissiel: :D
13:17 <@zyga> kissiel: http://bazaar.launchpad.net/~kissiel/checkbox/command-output-in-cbt/revision/3789
13:17 <@zyga> kissiel: can we just pass the whole Unit object (pyotherside 1.4)
13:17 < kissiel> zyga, for my defense - I wrote that bit before my first coffee
13:17 <@zyga> kissiel: (separate concern, I just don't want us to keep going down this road)
13:18 <@zyga> kissiel: :D
13:18 <@zyga> kissiel: no worries
13:18 <@zyga> kissiel: everything else looks good
13:18 <@zyga> kissiel: I need to run it but looks ok on paper
13:18 <@zyga> kissiel: the way we handle data can be simplified now
13:18 <@zyga> kissiel: though that can be a separate patchet
13:18 < kissiel> what data?
13:18 <@zyga> kissiel: and we need to think exactly how to do it, it simplifies a lot of stuff
13:18 <@zyga> kissiel: instead of patching our custom hack ...

<spineau> kissiel: if the tested decided to open the output page, when the test ends the page is closed automatically. I think it's more user-friendly to let the user decide when it has be be closed and move to the next test. It's frustrating to not have the time to copy paste the output

We've been waiting/dreaming for such a feature for as long I can remember, +1000

Attempt to merge into lp:checkbox failed due to conflicts:

text conflict in checkbox-touch/py/checkbox_touch.py

Branch rebased and tested.
Self-approving.