Merge lp://qastaging/~kissiel/checkbox/comments-in-cbt into lp://qastaging/checkbox
Proposed by
Maciej Kisielewski
| Status: | Merged |
|---|---|
| Approved by: | Zygmunt Krynicki |
| Approved revision: | 3953 |
| Merged at revision: | 3949 |
| Proposed branch: | lp://qastaging/~kissiel/checkbox/comments-in-cbt |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
285 lines (+162/-0) 8 files modified
checkbox-touch/checkbox-touch.qml (+3/-0) checkbox-touch/components/CommentsDialog.qml (+81/-0) checkbox-touch/components/InteractIntroPage.qml (+13/-0) checkbox-touch/components/ManualIntroPage.qml (+13/-0) checkbox-touch/components/QmlConfinedPage.qml (+13/-0) checkbox-touch/components/QmlNativePage.qml (+13/-0) checkbox-touch/components/TestVerificationPage.qml (+13/-0) checkbox-touch/components/UserInteractSummaryPage.qml (+13/-0) |
| To merge this branch: | bzr merge lp://qastaging/~kissiel/checkbox/comments-in-cbt |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
| Brendan Donegan (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This MR brings commenting feature to Checkbox-Converged
935f6db checkbox-touch: add "add comment" dialog
1a8ac1f checkbox-touch: add CommentDialog instance
833805e checkbox-touch: add commenting option to test pages
f72ae9d checkbox-touch: retain comments in between steps
9ebc1f2 checkbox-touch: document CommentDialog
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
From a functional point of view this works well - thanks!