Merge lp://qastaging/~kissiel/checkbox/fix-1493713-category-selection into lp://qastaging/checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 4003
Merged at revision: 4001
Proposed branch: lp://qastaging/~kissiel/checkbox/fix-1493713-category-selection
Merge into: lp://qastaging/checkbox
Diff against target: 59 lines (+26/-0)
2 files modified
checkbox-touch/py/checkbox_touch.py (+2/-0)
plainbox/plainbox/impl/session/assistant.py (+24/-0)
To merge this branch: bzr merge lp://qastaging/~kissiel/checkbox/fix-1493713-category-selection
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+270814@code.qastaging.launchpad.net

Description of the change

This MR fixes a problem where going back from test selection screen to category selection screen and selecting different set of categories would make tests disappear.

8f56fd6 plainbox:session:assitant: enforce usage expectations on filter_by_category
c4cf14a plainbox:session:assistant: add "remove_all_filters" method
d70f1de checkbox-touch: remove category filters when applying a new one

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

thanks for the fix, just in time (I was about to kick off ppa testing builds), +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches