Merge lp://qastaging/~kissiel/checkbox/fix-mem-inflation into lp://qastaging/checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3992
Merged at revision: 3992
Proposed branch: lp://qastaging/~kissiel/checkbox/fix-mem-inflation
Merge into: lp://qastaging/checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
checkbox-touch/components/CommandOutputPage.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~kissiel/checkbox/fix-mem-inflation
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+270328@code.qastaging.launchpad.net

Description of the change

This MR fixes mem problem in Checkbox-Converged

CommandOutput page used a buffer that was filled with the strings that job's command printed and periodically timer synced that output onto the text area. As the buffer qml's "property string" was used. This somehow broke garbage collecting and the strings were never freed from memory. By changing the type to 'property var' fixed all problems.

Why?

I don't know.

Here: http://paste.ubuntu.com/12310269/ is the code I did to pinpoint where/how the problem may be solved. If you want to reproduce the bug, in the pastebinned code change the type of bufferedIO from 'var' to 'string'.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Wow, pretty amazing. We should ask our qml overlords. Fantastic find btw.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches