Merge lp://qastaging/~kissiel/checkbox/fix-mem-inflation into lp://qastaging/checkbox
Proposed by
Maciej Kisielewski
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Zygmunt Krynicki | ||||
Approved revision: | 3992 | ||||
Merged at revision: | 3992 | ||||
Proposed branch: | lp://qastaging/~kissiel/checkbox/fix-mem-inflation | ||||
Merge into: | lp://qastaging/checkbox | ||||
Diff against target: |
12 lines (+1/-1) 1 file modified
checkbox-touch/components/CommandOutputPage.qml (+1/-1) |
||||
To merge this branch: | bzr merge lp://qastaging/~kissiel/checkbox/fix-mem-inflation | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+270328@code.qastaging.launchpad.net |
Description of the change
This MR fixes mem problem in Checkbox-Converged
CommandOutput page used a buffer that was filled with the strings that job's command printed and periodically timer synced that output onto the text area. As the buffer qml's "property string" was used. This somehow broke garbage collecting and the strings were never freed from memory. By changing the type to 'property var' fixed all problems.
Why?
I don't know.
Here: http://
To post a comment you must log in.
Wow, pretty amazing. We should ask our qml overlords. Fantastic find btw.