Checkbox

Merge lp://qastaging/~kissiel/checkbox/rerun-in-cbt into lp://qastaging/checkbox

  1. rerun-in-cbt
  2. Merge into trunk
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3917
Merged at revision: 3914
Proposed branch: lp://qastaging/~kissiel/checkbox/rerun-in-cbt
Merge into: lp://qastaging/checkbox
Diff against target: 323 lines (+168/-33)
6 files modified
checkbox-touch/checkbox-touch.qml (+34/-1)
checkbox-touch/components/CheckboxTouchApplication.qml (+6/-0)
checkbox-touch/components/SelectionPage.qml (+3/-1)
checkbox-touch/py/checkbox_touch.py (+22/-0)
checkbox-touch/tests/autopilot/checkbox_touch/__init__.py (+33/-0)
checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+70/-31)
To merge this branch: bzr merge lp://qastaging/~kissiel/checkbox/rerun-in-cbt
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+265232@code.qastaging.launchpad.net

Description of the change

This MR brings re-run feature to checkbox-{touch|converged}

6e98004 chekcbox-touch: add function getting rerun candidates to py logic
d873a99 checkbox-touch: invalidate cache and reset index when tests are started
a7feee8 checkbox-touch: add proxy-ing to get rerun candidates in qml logic
214224d checkbox-touch: add emptyAllowed option to selection screen
e58246e checkbox-touch: add rerun screen
2db9319 checkbox-touch: run re-run before results screen
5d71b5b checkbox-touch:autopilot: move processing clicks helper to top-class
c0e491a checkbox-touch:autopilot: add generic check_results helper
7d49391 checkbox-touch:autopilot: add re-run scenarios for AP

To post a comment you must log in.
lp://qastaging/~kissiel/checkbox/rerun-in-cbt updated
3905. By Zygmunt Krynicki

"automatic merge of lp:~zyga/checkbox/fix-1476136/ by tarmac [r=sylvain-pineau][bug=1476136][author=zyga]"

3906. By Maciej Kisielewski

"automatic merge of lp:~kissiel/checkbox/remove-lxml-from-cbt-reqs/ by tarmac [r=sylvain-pineau,zyga][bug=][author=kissiel]"

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

When we landed the same feature for checkbox-cli, I thought that being unable to rerun every test would miss. But actually the only concern was about selection of all jobs dependencies (i.e suspend again if the test was depending on suspend_auto). So I agree with the decision to only select failed/crash test results.

Tests are presented with their respective categories which is great (clearly lacking in checkbox-gui).

So conclusion is a +1 for the design choices.

I ran the following sequence which was crashing the app:

- selected both sensor and screen categories from the qml provider
- failed one in each category
- rerun one succesfully
- killed cbt with a swipe move on the screen
- when prompted to resume the session selected rerun last test
- failed again the test "ensure haptics are working"
- at the final screen, select finish
- cbt controls are greyed out, app is blocked

The upstart log: http://pastebin.ubuntu.com/11918666/

review: Needs Fixing
lp://qastaging/~kissiel/checkbox/rerun-in-cbt updated
3907. By Maciej Kisielewski

checkbox-touch: remember test_plan_id once it's selected

Signed-off-by: Maciej Kisielewski <email address hidden>

3908. By Maciej Kisielewski

checkbox-touch: make resuming re-initiate test-plan

Signed-off-by: Maciej Kisielewski <email address hidden>

3909. By Maciej Kisielewski

chekcbox-touch: add function getting rerun candidates to py logic

Signed-off-by: Maciej Kisielewski <email address hidden>

3910. By Maciej Kisielewski

checkbox-touch: invalidate cache and reset index when tests are started

Signed-off-by: Maciej Kisielewski <email address hidden>

3911. By Maciej Kisielewski

checkbox-touch: add proxy-ing to get rerun candidates in qml logic

Signed-off-by: Maciej Kisielewski <email address hidden>

3912. By Maciej Kisielewski

checkbox-touch: add emptyAllowed option to selection screen

This patch adds an option to SelectionPage component that lets user proceed
even if nothing is selected.

Signed-off-by: Maciej Kisielewski <email address hidden>

3913. By Maciej Kisielewski

checkbox-touch: add rerun screen

Signed-off-by: Maciej Kisielewski <email address hidden>

3914. By Maciej Kisielewski

checkbox-touch: run re-run before results screen

Signed-off-by: Maciej Kisielewski <email address hidden>

3915. By Maciej Kisielewski

checkbox-touch:autopilot: move processing clicks helper to top-class

This patch moves the helper that executes common scenario of clicking through
pages, to the ClickAppTestCase class, so all our test classes inherit this.

Signed-off-by: Maciej Kisielewski <email address hidden>

3916. By Maciej Kisielewski

checkbox-touch:autopilot: add generic check_results helper

This patch adds a helper function that checks if the result screen is shown
with the expected values.

Signed-off-by: Maciej Kisielewski <email address hidden>

3917. By Maciej Kisielewski

checkbox-touch:autopilot: add re-run scenarios for AP

Signed-off-by: Maciej Kisielewski <email address hidden>

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> When we landed the same feature for checkbox-cli, I thought that being unable
> to rerun every test would miss. But actually the only concern was about
> selection of all jobs dependencies (i.e suspend again if the test was
> depending on suspend_auto). So I agree with the decision to only select
> failed/crash test results.
>
> Tests are presented with their respective categories which is great (clearly
> lacking in checkbox-gui).
>
> So conclusion is a +1 for the design choices.
>
> I ran the following sequence which was crashing the app:
>
> - selected both sensor and screen categories from the qml provider
> - failed one in each category
> - rerun one succesfully
> - killed cbt with a swipe move on the screen
> - when prompted to resume the session selected rerun last test
> - failed again the test "ensure haptics are working"
> - at the final screen, select finish
> - cbt controls are greyed out, app is blocked
>
> The upstart log: http://pastebin.ubuntu.com/11918666/

Rerun + resume now works. Tested with your scenario, and the scenario when resume is done before any job is rerun.

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Re tested, it works! Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches