Merge lp://qastaging/~kissiel/checkbox/sa-in-cbt into lp://qastaging/checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3997
Merged at revision: 3970
Proposed branch: lp://qastaging/~kissiel/checkbox/sa-in-cbt
Merge into: lp://qastaging/checkbox
Diff against target: 958 lines (+248/-396)
5 files modified
checkbox-touch/checkbox-touch.qml (+39/-32)
checkbox-touch/components/CheckboxTouchApplication.qml (+4/-4)
checkbox-touch/py/checkbox_touch.py (+135/-327)
checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+33/-30)
plainbox/plainbox/impl/session/assistant.py (+37/-3)
To merge this branch: bzr merge lp://qastaging/~kissiel/checkbox/sa-in-cbt
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+269634@code.qastaging.launchpad.net

Description of the change

This MR brings a small revolution to Checkbox {Touch,Converged}.

It replaces all the internal logic related to running plainbox core with calls to SessionAssistant.
It also smuggles some fixes to SessionAssistant along the way.
Then, it makes Autopilot happy with the New Order,
to finally clean up pep8 issues, embetter existing and add missing docstrings.

a6b1280 checkbox-touch: run run_test_activity for ALL plugins
e30f8f1 checkbox-touch: [move2SA] use SA in __init__
7de6bda checkbox-touch: [move2SA] use SA in start_session
861c36a checkbox-touch: [move2SA] use SA in is_session_resumable
bedf971 checkbox-touch: [move2SA] use SA in get_testplans
7e1e3a2 checkbox-touch: [move2SA] use SA in remember_testplan
037f79a checkbox-touch: [move2SA] use SA in get_categories
a853d86 checkbox-touch: [move2SA] use SA in remember_categories
9e08a76 checkbox-touch: [move2SA] use SA in get_available tests
2fe8eeb checkbox-touch: [move2SA] use SA in get_rerun_candidates
2fcc534 checkbox-touch: [move2SA] use SA in remember_tests
3a6c5cb checkbox-touch: [move2SA] use SA in get_next_test
d8fc496 checkbox-touch: [move2SA] use SA in register_test_result
2fd2af9 checkbox-touch: [move2SA] use SA in run_test_activity
952d973 checkbox-touch: [move2SA] use SA in get_results
225b491 checkbox-touch: [move2SA] use SA in export_results
f66a3b6 checkbox-touch: add timestamp to app_blob
dfce594 checkbox-touch: [move2SA] remove _checkpoint method
d3f7f14 checkbox-touch: add a method for loading embedded providers
85e9416 checkbox-touch:autopilot: rearrange order of full-scenario to match SA sorting
e507f79 plainbox:session:assistant: correct UsageExpectations after session is started
a0e3297 plainbox:session:assistant: allow export_to_file call in 'normal' state
37153b4 checkbox-touch: move embedded providers stuff to CBTApp.__init__
41c813e plainbox:session:assistant: require select_test_plan after resume
73adaa6 plainbox:session:assistant: add finalize_session method
db9146c checkbox-touch:[move2SA] use SA in clear_session
d24664e checkbox-touch: remove unnecessary methods
e45942c checkbox-touch: remove import of no longer used modules
dc61ce2 checkbox-touch: fix PEP8 issues
70148a8 checkbox-touch: upgrade docstrings

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

let there be light

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches