Merge lp://qastaging/~kissiel/checkbox/validate-providers-in-cbt into lp://qastaging/checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3915
Merged at revision: 3920
Proposed branch: lp://qastaging/~kissiel/checkbox/validate-providers-in-cbt
Merge into: lp://qastaging/checkbox
Diff against target: 46 lines (+29/-0)
1 file modified
checkbox-touch/build-me (+29/-0)
To merge this branch: bzr merge lp://qastaging/~kissiel/checkbox/validate-providers-in-cbt
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+265968@code.qastaging.launchpad.net

Description of the change

Validation of providers when building CBT.

This patch make build-me run validate command on every provider in
'checkbox-touch/providers' directory. If the problem with validation is not
caused by invalid provider content (i.e. missing plainbox or directory not
being a provider), then user-friendly message is shown.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Look at some of the small things below.

review: Needs Fixing
3915. By Maciej Kisielewski

checkbox-touch: validate providers when building click

This patch make build-me run validate command on every provider in
'checkbox-touch/providers' directory. If the problem with validation is not
caused by invalid provider content (i.e. missing plainbox or directory not
being a provider), then user-friendly message is shown.

Signed-off-by: Maciej Kisielewski <email address hidden>

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> Look at some of the small things below.

Formatting changed to .format(...)

Capturing of FileNotFoundError changed to OSError.

pushed

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches