Hardware Certification Tools

Merge ~kissiel/hwcert-tools:add-beta-snap-build-step into hwcert-tools:mini-ci-legacy

  1. Git
  2. lp:~kissiel/hwcert-tools
  3. add-beta-snap-build-step
  4. Merge into mini-ci-legacy
Proposed by Maciej Kisielewski
Status: Needs review
Proposed branch: ~kissiel/hwcert-tools:add-beta-snap-build-step
Merge into: hwcert-tools:mini-ci-legacy
Diff against target: 74 lines (+43/-11)
1 file modified
src/www/snapcraft/run-snapcraft-test.sh (+43/-11)
Reviewer Review Type Date Requested Status
Taihsiang Ho (community) Needs Fixing
Jonathan Cave Approve
Review via email: mp+321148@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-03-22.

Description of the change

Snapcraft Testing: bring testing of beta branch and tidy up the scripts

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Looks good to me.

Thanks for adding the --devmode and also the testing of beta. As both edge and beta are essentially rolling builds I think it is good to test these.

review: Approve
Reply
Revision history for this message
Taihsiang Ho (tai271828) wrote : Posted in a previous version of this proposal

We need this story https://trello.com/c/zzQ1cetn/552-when-i-work-on-tools-scripts-for-the-tpe-lab-i-want-them-to-be-organized-under-a-sub-project-like-checkbox-project-so-i-can-know
to avoid using branches as repos ; )

Revision history for this message
Taihsiang Ho (tai271828) wrote :

Dry-run did not pass on real mini-ci. I did not get the email notification. I tried to manually reproduce again but the flow interrupted. I will check this is caused by this change or the mini-ci framework itself.

I rolled back to another version with --devimode appended only for the current production mini-ci.

Reply
Revision history for this message
Jonathan Cave (jocave) wrote :

I think a true negative is better than a false positive

Reply
Revision history for this message
Taihsiang Ho (tai271828) wrote :

Agree.

My previous comment meant that dry-run did not run through the test because something crashed. That is, mini-ci for checkbox-snappy build died. All the emails sent today were not from this MR. I am checking the root cause.

Reply
Revision history for this message
Taihsiang Ho (tai271828) wrote :

It seems that smoke-test has warm reboot test now to cause the weird behavior of mini-ci. mini-ci does not expect reboot during the test unit. Reboot confuses mini-ci. I will fix mini-ci to fit this checkbox-snappy test by checking if the systemd file is there for the reboot test job.

I will merge mini-ci fix first and then this test script.

Reply
Revision history for this message
Taihsiang Ho (tai271828) wrote :

I realized the reboot test of smoke-test[1] could not trace the this test script as well and not only make the mini-ci itself confused. Please see my line comments.

The first thing came to my mind is to prepare another specific test plan for mini-ci rather than an updated test script and changing the flow of the current mini-ci, because it is easier and won't affect the other components in the mini-ci flow, which is not designated to be able to trace reboot status.

[1]

------------[ Running job 471 / 494. Estimated time left: unknown ]-------------
---------------------------[ Perform warm reboot 1 ]----------------------------
ID: 2013.com.canonical.certification::warm-boot-loop-reboot1
Category: 2013.com.canonical.certification::stress-tests/warm-boot
Waiting for the system to shut down or reboot...
Created symlink from /etc/systemd/system/multi-user.target.wants/plainbox-autostart.service to /etc/systemd/system/plainbox-autostart.service.
... 8< -------------------------------------------------------------------------
Connection to 10.101.48.116 closed by remote host.
Connection to 10.101.48.116 closed.

review: Needs Fixing
Reply

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches