Merge ~kissiel/plainbox:restartable-fixes into plainbox:master

That's a good fix, but to me it's not enough as to set the restart_cmd_callback in sa, checkbox-cli run command would need to call the Launcher method _configure_restart (maybe something to move to the stage module). What do you think? (otherwise with the run command, we'll never write the magic file in the session folder)

Yeah!
When I wrote the above patch, I checked usages of the restart_cmd_callback var. The only other use is when autorestart is configured, i.e. sa._restart_strategy is not None. And this is always set if client code called configure_application_restart (it's usually done, as you've mentioned from Launcher).

If you'd like I can add additional code asserting that's really the state (theoretically someone can still supply "None" as the callback from a new plainbox app, or by accident from a new patch to Launchers).

+1 for the fix in plainbox. Indeed nothing else really needed at this level. For the checkbox-cli run command, we should have a look at making the launcher and run invoke() methods working the same way (i.e configuring the restart)

I tried to merge it but there are some problems. Typically you want to merge or rebase and try again.

The merge was fine but running tests failed.

I can't run /usr/bin/lxc-create, maybe you need to give me sudo permissions
I can't run /usr/bin/lxc-start, maybe you need to give me sudo permissions
I can't run /usr/bin/lxc-stop, maybe you need to give me sudo permissions
I can't run /usr/bin/lxc-destroy, maybe you need to give me sudo permissions
I can't run /usr/bin/lxc-attach, maybe you need to give me sudo permissions
I can't run /usr/bin/lxc-wait, maybe you need to give me sudo permissions
I can't run /usr/bin/lxc-info, maybe you need to give me sudo permissions

PMR problem, trying again

I tried to merge it but there are some problems. Typically you want to merge or rebase and try again.

The merge was fine but running tests failed.

[trusty] creating pristine container
[trusty] (timing) 99.70user 14.04system 10:47.32elapsed 17%CPU (0avgtext+0avgdata 103352maxresident)k
[trusty] (timing) 712296inputs+3096936outputs (551major+3684798minor)pagefaults 0swaps
[trusty] starting container
[trusty] Unable to start ephemeral container!
[trusty] stdout: https://paste.ubuntu.com/25368825/
[trusty] stderr: https://paste.ubuntu.com/25368826/
[trusty] NOTE: unable to execute tests, marked as failed
[trusty] Destroying failed container to reclaim resources
[xenial] creating pristine container
[xenial] (timing) 138.58user 14.05system 10:14.82elapsed 24%CPU (0avgtext+0avgdata 108000maxresident)k
[xenial] (timing) 190120inputs+3147712outputs (413major+4729902minor)pagefaults 0swaps
[xenial] starting container
[xenial] Unable to start ephemeral container!
[xenial] stdout: https://paste.ubuntu.com/25368855/
[xenial] stderr: https://paste.ubuntu.com/25368856/
[xenial] NOTE: unable to execute tests, marked as failed
[xenial] Destroying failed container to reclaim resources

The merge was fine but running tests failed.

[trusty] starting container
[trusty] Unable to start ephemeral container!
[trusty] stdout: https://paste.ubuntu.com/25368912/
[trusty] stderr: https://paste.ubuntu.com/25368913/
[trusty] NOTE: unable to execute tests, marked as failed
[trusty] Destroying failed container to reclaim resources
[xenial] starting container
[xenial] Unable to start ephemeral container!
[xenial] stdout: https://paste.ubuntu.com/25368914/
[xenial] stderr: https://paste.ubuntu.com/25368915/
[xenial] NOTE: unable to execute tests, marked as failed
[xenial] Destroying failed container to reclaim resources