Merge lp://qastaging/~klap-in/compiz/bug904205 into lp://qastaging/compiz/0.9.8

Proposed by klap-in
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3276
Merged at revision: 3276
Proposed branch: lp://qastaging/~klap-in/compiz/bug904205
Merge into: lp://qastaging/compiz/0.9.8
Diff against target: 49 lines (+10/-10)
1 file modified
plugins/wall/src/wall.cpp (+10/-10)
To merge this branch: bzr merge lp://qastaging/~klap-in/compiz/bug904205
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Sam Spilsbury Approve
Review via email: mp+113058@code.qastaging.launchpad.net

Commit message

Using the next/previous bindings the wall plugin didn't calculate correctly the next workspace when it reaches the begin or the end of a row of workspaces, so it didn't jump to the next line. (LP: #904205)

Description of the change

Using the next/previous bindings the wall plugin didn't calculate correctly the next workspace when it reachs the begin or the end of a row of workspaces, so it didn't jump to the next line.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Looks fine. This code looks pretty testable on its own, so it would be good if someone could get this under test before we merge it. (Time permitting)

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I've tested everything I can think of with respect to wall sliding, layouts and wrapping. All works well.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches