Merge lp://qastaging/~knightrider0xd/openlp/auto-scroll-choice into lp://qastaging/openlp
Proposed by
Ian Knight
| Status: | Merged |
|---|---|
| Approved by: | Tim Bentley |
| Approved revision: | 2645 |
| Merged at revision: | 2644 |
| Proposed branch: | lp://qastaging/~knightrider0xd/openlp/auto-scroll-choice |
| Merge into: | lp://qastaging/openlp |
| Diff against target: |
302 lines (+168/-12) 4 files modified
openlp/core/common/settings.py (+2/-1) openlp/core/ui/advancedtab.py (+41/-0) openlp/core/ui/listpreviewwidget.py (+21/-9) tests/functional/openlp_core_ui/test_listpreviewwidget.py (+104/-2) |
| To merge this branch: | bzr merge lp://qastaging/~knightrider0xd/openlp/auto-scroll-choice |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Bentley | Approve | ||
| Raoul Snyman | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-04-16.
Description of the change
Allows users to change the automatic scrolling behaviour for when a new slide is selected.
Currently on selecting a new slide, the next slide will be scrolled into view.
The changes provide a combo-box in the advanced settings that allow users to select additional options (see branch description for details).
Additional bounds checking and unit tests have been added to support this.
This latest proposal also contains additional input validation and testing thereof for values from Settings() which are added across several extra functions not otherwise affected by this feature.
To post a comment you must log in.
Revision history for this message
| Ian Knight (knightrider0xd) wrote | # |
Revision history for this message
| Raoul Snyman (raoul-snyman) | # |
review:
Approve
Revision history for this message
| Tim Bentley (trb143) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just a small code tweak, but otherwise this looks good!