Merge lp://qastaging/~knightrider0xd/openlp/preview-shows-live-fix-1080596 into lp://qastaging/openlp
Proposed by
Ian Knight
| Status: | Merged |
|---|---|
| Merged at revision: | 2661 |
| Proposed branch: | lp://qastaging/~knightrider0xd/openlp/preview-shows-live-fix-1080596 |
| Merge into: | lp://qastaging/openlp |
| Diff against target: |
687 lines (+472/-19) 9 files modified
openlp/core/lib/__init__.py (+26/-2) openlp/core/lib/serviceitem.py (+2/-0) openlp/core/ui/lib/listpreviewwidget.py (+8/-6) openlp/core/ui/slidecontroller.py (+15/-3) openlp/plugins/presentations/lib/presentationcontroller.py (+2/-2) tests/functional/openlp_core_lib/test_lib.py (+190/-2) tests/functional/openlp_core_lib/test_serviceitem.py (+5/-2) tests/functional/openlp_core_ui/test_slidecontroller.py (+170/-1) tests/functional/openlp_core_ui_lib/test_listpreviewwidget.py (+54/-1) |
| To merge this branch: | bzr merge lp://qastaging/~knightrider0xd/openlp/preview-shows-live-fix-1080596 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Bentley | Approve | ||
| Raoul Snyman | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-05-06.
Description of the change
Fixes bug 1080596 where presentations in the preview pane display live view rather than preview of selected slide.
In addition, fixes the aspect ratio & quality of thumbnails by saving them in the correct aspect ratio at a higher resolution, and loading them through the image manager.
New test cases implemented, or existing cases modified to test coverage complete for changes.
lp:~knightrider0xd/openlp/preview-shows-live-fix-1080596 (revision 2652)
[SUCCESS] https:/
[SUCCESS] https:/
Failing interface & coverage tests due to issue with unrelated crosswalk import module.
To post a comment you must log in.
Revision history for this message
| Tim Bentley (trb143) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just one clarification?