Merge ~kobako/ubuntu/+source/alsa-ucm-conf:LP2015972_J into ubuntu/+source/alsa-ucm-conf:ubuntu/jammy-proposed

Proposed by koba
Status: Needs review
Proposed branch: ~kobako/ubuntu/+source/alsa-ucm-conf:LP2015972_J
Merge into: ubuntu/+source/alsa-ucm-conf:ubuntu/jammy-proposed
Diff against target: 71 lines (+49/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch (+41/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
git-ubuntu import Pending
Review via email: mp+441279@code.qastaging.launchpad.net

Description of the change

BugLink: https://bugs.launchpad.net/bugs/2015972

[Feature Description]
When users press the speaker mute hotkey and the speaker is muted,
the speaker mute LED indicator will light up.
When the speaker is not muted,
the speaker mute LED indicator will light out.

[Test Case]
1. run G16 with target kernel.
2. press the mute hotkey
3. check if speaker mute led can be switched.

[Where problems could occur]
Low, just register a speaker mute led control for dell-laptop.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your contribution, the change should not be inline though but in debian/patches and you should have a debian/changelog entry explaining the fix and referencing to the launchpad bug to close

review: Needs Fixing
Revision history for this message
koba (kobako) wrote :

@Seb128, thanks for reviewing and comment,
Have modified as per your comment,
1. add patch to debian/patches
2. add a entry in d/changelog

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've uploaded now but I don't have the right the change the status of the MP on gitubuntu

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: