Merge lp://qastaging/~kriomant/do-plugins/transmission into lp://qastaging/do-plugins

Oh, wow. Sorry for missing this for so long!

This looks good. I've only got two minor niggles, and one larger one. The two minor ones are: you should have copyright headers on the files you've created, and I'd generally use a lot more automatic properties rather than explicit private _foo variables.

The major one is that it bundles a binary copy of Jayrock.Json. We generally try to minimise the binaries we bundle in the source tree; most distributions will not accept packages with binaries bundled like this.

Given the terrible length of time that this has been waiting for a review, I'm happy to make these changes myself if you don't want to. I would like your email address, though, so that I can credit you in the Authors file properly.

On 11 Dec 2011 10:16, "Chris Halse Rogers" <email address hidden> wrote:
>
> Review: Needs Fixing
>
> Oh, wow. Sorry for missing this for so long!

I thought development is completely stalled.

> This looks good. I've only got two minor niggles, and one larger one.
 The two minor ones are: you should have copyright headers on the files
you've created, and I'd generally use a lot more automatic properties
rather than explicit private _foo variables.
>
> The major one is that it bundles a binary copy of Jayrock.Json. We
generally try to minimise the binaries we bundle in the source tree; most
distributions will not accept packages with binaries bundled like this.

How will you solve this? I haven't found JSON library for Mono in standard
Ubuntu distribution. Will you include source code of Jayrock?

> Given the terrible length of time that this has been waiting for a
review, I'm happy to make these changes myself if you don't want to. I
would like your email address, though, so that I can credit you in the
Authors file properly.

It would be good.
My address is "Mikhail Trishchenkov <email address hidden>"

One more question: should I write wiki page?

> --
> https://code.launchpad.net/~kriomant/do-plugins/transmission/+merge/30966
> You are the owner of lp:~kriomant/do-plugins/transmission.

I wouldn't bother writing a wiki page; I plan to take the wiki down, as it's become a hive of spam and villany and I don't have time to curate it properly.

I'll transfer the documentation into a local format, so it can be installed alongside the plugins. Once I've got that set up, you might want to add documentation there.

As for the JSON library, I'll see if Hyena.Json does what needs to be done here. If not, I'll grab the Jayrock source code and package it.

Is there any progress?

On Tue, 2012-01-10 at 17:33 +0000, kriomant wrote:
> Is there any progress?

Not on this, sorry. I'm slowly working my way through the blocker bugs
for the next core release. I hope to have that done this week or early
next week.

After I've done that I'll be able to work on plugins stuff, of which
this will be the first priority.

Bump

I have an impression that "this week" have already passed...

The longest week ever has ended!