Merge lp://qastaging/~kroq-gar78/simple-scan/fix-765780 into lp://qastaging/~simple-scan-team/simple-scan/trunk
Proposed by
Aditya V
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~kroq-gar78/simple-scan/fix-765780 |
| Merge into: | lp://qastaging/~simple-scan-team/simple-scan/trunk |
| Diff against target: |
31 lines (+10/-4) 1 file modified
src/book.vala (+10/-4) |
| To merge this branch: | bzr merge lp://qastaging/~kroq-gar78/simple-scan/fix-765780 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aditya V (community) | Needs Resubmitting | ||
| Robert Ancell | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-04-11.
Description of the change
Add the page number to the first file in a multi-file scan, and start counting from one for multi-file scans.
To post a comment you must log in.
Revision history for this message
| Robert Ancell (robert-ancell) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi,
Thanks very much for that! The functionality of the patch is correct, but do you mind changing the way it works? It's a little bit complicated the way it is.
Instead of having the separate loop when get_n_pages() == 1 make make_indexed_file() take a new argument 'n_pages'. If n_pages == 0 then don't modify the name, otherwise put the numeric suffix on it.
Also note the pages should start at one as requested by Michael in the bug report.