Merge lp://qastaging/~kroq-gar78/ubuntu/precise/dkms/fix-989998 into lp://qastaging/ubuntu/precise/dkms
Proposed by
Aditya V
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~kroq-gar78/ubuntu/precise/dkms/fix-989998 |
| Merge into: | lp://qastaging/ubuntu/precise/dkms |
| Diff against target: |
33 lines (+10/-1) 2 files modified
debian/changelog (+6/-0) debian/control (+4/-1) |
| To merge this branch: | bzr merge lp://qastaging/~kroq-gar78/ubuntu/precise/dkms/fix-989998 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Felix Geyer (community) | Disapprove | ||
| Ubuntu branches | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-05-28.
Description of the change
I added 'dpkg-dev' and 'debhelper' to Depends in debian/control.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Most of the time dkms is only used for building kernel modules so adding them as dependecies is the wrong solution.
dkms is on various CDs so adding them to Depends or Recommends would also waste some space on the images.
Adding dpkg-dev and debhelper to Suggests and ensuring that dkms has a sensible error message if they are missing seems like the best solution to me.