Merge lp://qastaging/~ksamak/compiz/add_startup_option_to_negative into lp://qastaging/compiz/0.9.13

Proposed by ksamak
Status: Superseded
Proposed branch: lp://qastaging/~ksamak/compiz/add_startup_option_to_negative
Merge into: lp://qastaging/compiz/0.9.13
Diff against target: 28 lines (+12/-0)
1 file modified
plugins/neg/src/neg.cpp (+12/-0)
To merge this branch: bzr merge lp://qastaging/~ksamak/compiz/add_startup_option_to_negative
Reviewer Review Type Date Requested Status
Sam Spilsbury Needs Fixing
Marco Trevisan (TreviƱo) Pending
Review via email: mp+315202@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2017-01-26.

Commit message

neg: added hook to react to change in ccsm, for autostart option

Description of the change

neg: added hook to react to change in ccsm, for autostart option

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Needs Fixing
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> optionSetActivateAtStartupNotify (boost::bind (&NegScreen::optionChanged, this,
> _1, _2));

This is also incorrect - it will cause all windows to be toggled whenever the option is changed, not just on startup.

Revision history for this message
ksamak (ksamak) wrote :

> > optionSetActivateAtStartupNotify (boost::bind (&NegScreen::optionChanged,
> this,
> > _1, _2));
>
> This is also incorrect - it will cause all windows to be toggled whenever the
> option is changed, not just on startup.

Yes, this is a suggestion made by 3v1n0, that when the user switches this option in ccsm, he sees a immediate reaction. This ensures the user that changes have been taken into account
This switches all windows immediately indeed. Though i can think of no case where it is irrelevant.

4107. By ksamak <ksamak@ksalaptop>

fix coding style

4108. By ksamak <ksamak@ksalaptop>

fixed indent

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches