Connection Manager

Merge lp://qastaging/~kvalo/connman/ptp-default-gateway into lp://qastaging/~indicator-network-developers/connman/trunk

  1. ptp-default-gateway
  2. Merge into trunk
Proposed by Kalle Valo
Status: Merged
Merged at revision: 2272
Proposed branch: lp://qastaging/~kvalo/connman/ptp-default-gateway
Merge into: lp://qastaging/~indicator-network-developers/connman/trunk
Diff against target: 150 lines (+72/-9)
4 files modified
include/inet.h (+1/-0)
src/connection.c (+14/-7)
src/inet.c (+45/-0)
src/rtnl.c (+12/-2)
To merge this branch: bzr merge lp://qastaging/~kvalo/connman/ptp-default-gateway
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Review via email: mp+26694@code.qastaging.launchpad.net

Description of the change

Fix for default interface problem.

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

Comments and needs info:
- the del_routes changes seem correct to me
- connman_inet_clear_gateway_interface looks good to me
- rntl: sounds ok, but i'm not sure how safe it is to skip those host-specific routes

My only worry is about swapping a NULL for a "0.0.0.0" string. You've done the changes locally, but are there other parts of the code (or of plugins) where gateway != NULL (because it's now "0.0.0.0") would be mis-interpreted? Have you grepped for that in the rest of the code?

review: Needs Information
Revision history for this message
Kalle Valo (kvalo) wrote :

Fortunately struct gateway_data is only used inside src/connections.c and I reviewed the cases in that file and they look to be ok.

Revision history for this message
David Barth (dbarth) wrote :

Ok +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches