Merge lp://qastaging/~kwmonroe/charms/trusty/layer-ibm-im/switch-to-resources into lp://qastaging/~ibmcharmers/charms/trusty/layer-ibm-im/trunk

Proposed by Kevin W Monroe
Status: Merged
Approved by: Shruthima
Approved revision: 21
Merged at revision: 6
Proposed branch: lp://qastaging/~kwmonroe/charms/trusty/layer-ibm-im/switch-to-resources
Merge into: lp://qastaging/~ibmcharmers/charms/trusty/layer-ibm-im/trunk
Diff against target: 866 lines (+323/-463)
9 files modified
README.md (+115/-210)
config.yaml (+0/-6)
layer.yaml (+1/-0)
metadata.yaml (+13/-2)
reactive/ibm-im.sh (+161/-140)
tests/00-setup (+0/-21)
tests/01-deploy.py (+29/-0)
tests/10-bundles-test.py (+0/-84)
tests/tests.yaml (+4/-0)
To merge this branch: bzr merge lp://qastaging/~kwmonroe/charms/trusty/layer-ibm-im/switch-to-resources
Reviewer Review Type Date Requested Status
Shruthima Approve
Review via email: mp+296630@code.qastaging.launchpad.net

Description of the change

Switch to Juju Resources and Terms instead of requiring curl and license config options.

To post a comment you must log in.
13. By Kevin W Monroe

update fixpack placeholder description

14. By Kevin W Monroe

update tests since we can test charm deployment with a placeholder resource

15. By Kevin W Monroe

be more explicity with log/status messages

16. By Kevin W Monroe

never let the grep fail when detecting an empty fixpack (set -e will make the hook fail on subshell failures); make check-fixpack only run during upgrade-charm (otherwise it ran on update-status, every 5 minutes)

17. By Kevin W Monroe

use underscores instead of hyphens in function names

18. By Kevin W Monroe

fixup last commit (missed an extra ibm_im_fp_empty assignment)

19. By Kevin W Monroe

update sentry message for placeholder resource test

20. By Kevin W Monroe

tweak sentry status message in amulet test

21. By Kevin W Monroe

change upgrade-charm hook logic

The first time a fixpack resource was uploaded, the upgrade-charm hook would
fetch it, md5sum it, and compare that sum to a bogus previous value (because
there was no previous valid fixpack). This sum mismatch triggered the install
of a new fixpack, which goes out to re-fetch it. The double-fetch on initial
fixpack (first in upgrade-charm, then in install_ibm_im_fixpack) is
inefficient.

Instead, upgrade-charm now checks for the ibm-im.updated state, which is only
set when a fixpack gets installed. On initial fixpack upload, this state will
not be set, so we avoid the double fetch.

Revision history for this message
Shruthima (salmavar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches