Merge lp://qastaging/~kyrofa/snap-confine/create_user_common_data into lp://qastaging/~snappy-dev/snap-confine/trunk
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~kyrofa/snap-confine/create_user_common_data |
| Merge into: | lp://qastaging/~snappy-dev/snap-confine/trunk |
| Diff against target: |
292 lines (+140/-46) 2 files modified
src/main.c (+41/-6) tests/test_create_user_data (+99/-40) |
| To merge this branch: | bzr merge lp://qastaging/~kyrofa/snap-confine/create_user_common_data |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Snappy Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Create user-specific common snap data directory.
Description of the change
The newest version of Snappy now supports a unversioned ("common") snap data directory for both system-wide and user-specific data. Since the launcher currently creates the other user-specific data, it makes sense to include the user-specific common data as well.
There's a caveat, though. While Snappy supports common data directories, they're as-yet unnamed (i.e. they're not represented by environment variables). They do, however, have a specific path relative to SNAP_DATA and SNAP_USER_DATA, so this PR utilizes that. The launcher will need to be updated again once a name is chosen for these paths.
| Kyle Fazzari (kyrofa) wrote | # |
Unmerged revisions
- 136. By Kyle Fazzari
-
Should use calloc instead of malloc to zero-init string.
- 135. By Kyle Fazzari
-
Create user-specific common snap data directory.
The newest version of Snappy now supports a unversioned ("common") snap data
directory for both system-wide and user-specific data. Since the launcher
currently creates the other user-specific data, it makes sense to include
the user-specific common data as well.
Note the lack of profile changes here. This change seems to be covered under the current profile.