Merge lp://qastaging/~l3on/ubuntu-themes/gnome-shell-fixes into lp://qastaging/ubuntu-themes

I've given to this a first look and it seems very good...
However, in order to match the unity defined shadows you should use this:

.window-frame {
    border-radius: 10px 10px 0 0;
    box-shadow: 2px 10px 30px @window_shadow;

    /* this is used for the resize cursor area */
    margin: 10px;
}

.window-frame:backdrop {
    box-shadow: 2px 10px 25px @window_shadow_inactive;
}

Then, we've a problem... At least in unity: what in unity is a toolbar, using this theme becomes an headerbar and thus here it looks like we've two headers, which is something we can't go with.

So, I'm not sure weather it's the case of fixing nautilus or adding some special theming for Nautilus. I've noticed that using the Adwaita theme this problem doesn't happen here.

> I've given to this a first look and it seems very good...

Great!

> However, in order to match the unity defined shadows you should use this:
>
> .window-frame {
> border-radius: 10px 10px 0 0;
> box-shadow: 2px 10px 30px @window_shadow;
>
> /* this is used for the resize cursor area */
> margin: 10px;
> }
>
> .window-frame:backdrop {
> box-shadow: 2px 10px 25px @window_shadow_inactive;
> }

I tried, but I got an unexpected result. It seems blur effect used by GTK is not the same used by Unity. So, if you set the same values (@window_shadow*) you get different result.
It was true when I worked on windows, and I guess it's still so.

> Then, we've a problem... At least in unity: what in unity is a toolbar, using
> this theme becomes an headerbar and thus here it looks like we've two headers,
> which is something we can't go with.
> So, I'm not sure weather it's the case of fixing nautilus or adding some
> special theming for Nautilus.

Yes. You are right.
But the problem here is in Nautilus itself. The patch applied in the software (if I am not wrong) checks if current session is Unity, and if so, encloses the gtk-headerbar in a simple container.
The result is: you have a headerbar, supposed to be the "top-of-the-window", but displayed inside of it.
So, in this case, we have to review that patch (precisely: nautilus/debian/patches/ubuntu_show_titlebar.patch).

> I've noticed that using the Adwaita theme this
> problem doesn't happen here.
Only because in Adwaita headerbar and the other widgets use (more or less) the same colors.

> > However, in order to match the unity defined shadows you should use this:
> >
> > .window-frame {
> > border-radius: 10px 10px 0 0;
> > box-shadow: 2px 10px 30px @window_shadow;
> >
> > /* this is used for the resize cursor area */
> > margin: 10px;
> > }
> >
> > .window-frame:backdrop {
> > box-shadow: 2px 10px 25px @window_shadow_inactive;
> > }
>
> I tried, but I got an unexpected result. It seems blur effect used by GTK is
> not the same used by Unity. So, if you set the same values (@window_shadow*)
> you get different result.
> It was true when I worked on windows, and I guess it's still so.

Yeah, that's true. However using the values above I get exactly the same results (well, more or less :)), so I think you can safely use that I think.

> Yes. You are right.
> But the problem here is in Nautilus itself. The patch applied in the software
> (if I am not wrong) checks if current session is Unity, and if so, encloses
> the gtk-headerbar in a simple container.
> The result is: you have a headerbar, supposed to be the "top-of-the-window",
> but displayed inside of it.
> So, in this case, we have to review that patch (precisely:
> nautilus/debian/patches/ubuntu_show_titlebar.patch).

Right... Do you have time to check that or should I go?

> > I tried, but I got an unexpected result. It seems blur effect used by GTK is
> > not the same used by Unity. So, if you set the same values (@window_shadow*)
> > you get different result.
> > It was true when I worked on windows, and I guess it's still so.
>
> Yeah, that's true. However using the values above I get exactly the same
> results (well, more or less :)), so I think you can safely use that I think.

Ok, I will set that value.

About nautilus:
> > So, in this case, we have to review that patch (precisely:
> > nautilus/debian/patches/ubuntu_show_titlebar.patch).
>
> Right... Do you have time to check that or should I go?

I tried to remove '.header-bar' class from Nautilus toolbar. It just does not work, since you want "a dark bar" there, instead the result is:
http://i.imgur.com/bq8dXRb.png

So, I think the ways to fix this can be approximately two:
 1. Providing a theme hack to Nautilus, overriding the default style of ".header-bar"
 2. Otherwise, push into nautilus (and maybe more apps?) a ".header-bar.no-titlebar" style_class and then work on directly on css -> .no-titlebar

We need to move forward with this as currently gnome-panel theming is broken (since the last update).

Text conflict in Ambiance/gtk-3.0/gtk-widgets-assets.css
Text conflict in Ambiance/gtk-3.0/gtk-widgets-borders.css
Text conflict in Ambiance/gtk-3.0/gtk-widgets.css
Text conflict in Radiance/gtk-3.0/gtk-widgets-assets.css
Text conflict in Radiance/gtk-3.0/gtk-widgets-borders-radiance.css
Text conflict in Radiance/gtk-3.0/gtk-widgets-borders.css
Text conflict in Radiance/gtk-3.0/gtk-widgets.css